From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 7ad520c2 for ; Sat, 26 Jan 2019 20:42:23 +0000 (UTC) Received: (qmail 11133 invoked by alias); 26 Jan 2019 20:42:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44020 Received: (qmail 22692 invoked by uid 1010); 26 Jan 2019 20:42:10 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f169.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.169):SA:0(-1.9/5.0):. Processed in 2.400498 secs); 26 Jan 2019 20:42:10 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=9bMOE5x7Od81RJMnd9y8TBvF19a/UgSFtcF+/UYaBEc=; b=ReDE2SNN+9lkhjpJyt5RYDksUZxwThIRl7YdM8mOAXC4lPCpFyImU1IxMN9gsXbP+t 2Q3Y2ksSjn0dJpSiPipwFu3yeFO5LgJ4AgYKivN+PcmxiP6zy9Lvmc1FveBbpKJ0VLAb feQu+DWf2pgs0+g6f6QJDy4foO3OnaH5n/c3OYHK++5t/jXyybc75qDkGMBIeuHnt1wB tGV4M60L6tsnwaDbrtkXOBngX0rlbA4G9VgDwMJxlTkhM2f5Cfh1tmh4gSw6L9/xI/Id xJNLisBZ4SBQl/m7I/b76022+Dm2W076DrbaSQ8EgZVNFOacJVgZTlztHBOVqFf4vEKb +6Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=9bMOE5x7Od81RJMnd9y8TBvF19a/UgSFtcF+/UYaBEc=; b=b/EOIzEjb7788/fQFu00jZovTLh4+0J8zi3qNgunAMqShaywXajZFsApnlKL7Qxz1q rnXso2L50QalHWKHG6iXfIMUlPJiJRvxYj8B7evtIEXOMQxiRMEWD0vN87UCgtAa9CEx yRWI4VtBZBFMjvP+4Hvx7AmnWZ42JdffNgIxeazUlb5g67HDGLZaRbvegdOEb+imrCbj VMi0oINkB1VOWttrk8cwh1A0vMfa7gNcyfwEs5TCw5HP8gaBNQXvdx0VxVjLqyAiUefa 6CTqtnVYz30IgeHg6UU44VS+SPQzQA3imHoDFQEietGyPkDZbAxxVqDzsj20oVR8KUkc O6Vw== X-Gm-Message-State: AJcUukdLVuCx4P/CvAgvp6WY2gGFJ/+cgrRMZB9f5KmftR6qPRbmP92v i4h4BzptrhtUolwrR7mHf3XZCV+hJYg= X-Google-Smtp-Source: ALg8bN77rSlP1hC2rGV0iJCuOvpjBpwcTf6ik1fXoll4XyVgvtaLYh4uem1SDCWEsYZJrbvxv8x+0w== X-Received: by 2002:a02:59ca:: with SMTP id v71mr10018322jad.13.1548535325280; Sat, 26 Jan 2019 12:42:05 -0800 (PST) From: dana Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [PATCH] Fix broken VCS_Info in 5.7 Message-Id: <1458D79A-497E-41FB-AA4F-2F05EC969AD4@dana.is> Date: Sat, 26 Jan 2019 14:42:04 -0600 To: Zsh workers X-Mailer: Apple Mail (2.3445.100.39) A bunch of Arch users are reporting that VCS_Info is broken: https://bugs.archlinux.org/task/61533 To replicate it you just need to run vcs_info outside of a repo: % zsh -f % autoload -Uz vcs_info % vcs_info VCS_INFO_detect_p4:79: maximum nested function level reached; increase = FUNCNEST? This is apparently due to workers/43618, which introduced a function-def = guard to a function that wants to redefine itself. Just taking that back out = seems to fix it. Wish they'd mentioned it to #zsh an hour or two ago :( dana diff --git a/Functions/VCS_Info/Backends/VCS_INFO_detect_p4 = b/Functions/VCS_Info/Backends/VCS_INFO_detect_p4 index d171c68ee..5ec21da9f 100644 --- a/Functions/VCS_Info/Backends/VCS_INFO_detect_p4 +++ b/Functions/VCS_Info/Backends/VCS_INFO_detect_p4 @@ -44,7 +44,6 @@ VCS_INFO_p4_get_server() { } =20 =20 -(( ${+functions[VCS_INFO_detect_p4]} )) || VCS_INFO_detect_p4() { local serverport p4where =20