From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: [PATCH 5/5] _git: Complete fetchy refspecs correctly.
Date: Sat, 30 Apr 2016 00:48:19 +0000 [thread overview]
Message-ID: <1461977299-3770-6-git-send-email-danielsh@tarsus.local2> (raw)
In-Reply-To: <1461977299-3770-1-git-send-email-danielsh@tarsus.local2>
---
Completion/Unix/Command/_git | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index f0cc185..90789de 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -5369,8 +5369,19 @@ __git_ref_specs_pushy () {
(( $+functions[__git_ref_specs_fetchy] )) ||
__git_ref_specs_fetchy () {
- # TODO: this is wrong
- __git_ref_specs_pushy "$@"
+ # TODO: This needs to deal with a lot more types of things.
+ if compset -P '*:'; then
+ __git_heads_local
+ else
+ compset -P '+'
+ if compset -S ':*'; then
+ # TODO: have the caller supply the correct remote name, restrict to refs/remotes/${that_remote}/* only
+ __git_remote_branch_names_noprefix
+ else
+ # TODO: have the caller supply the correct remote name, restrict to refs/remotes/${that_remote}/* only
+ __git_remote_branch_names_noprefix -qS :
+ fi
+ fi
}
(( $+functions[__git_ref_specs] )) ||
prev parent reply other threads:[~2016-04-30 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 0:48 [PATCH 0/5] Completion: git refspecs Daniel Shahaf
2016-04-30 0:48 ` [PATCH 1/5] _git-bundle: Complete required file argument to 'git bundle' correctly Daniel Shahaf
2016-04-30 0:48 ` [PATCH 2/5] _git: Offer alternatives properly Daniel Shahaf
2016-04-30 0:48 ` [PATCH 3/5] _git: Fix an apparent typo in __git_heads() Daniel Shahaf
2016-04-30 0:48 ` [PATCH 4/5] _git: Bifurcate __git_ref_specs Daniel Shahaf
2016-04-30 0:48 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461977299-3770-6-git-send-email-danielsh@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).