From: Frank Terbeck <ft@bewatermyfriend.org>
To: zsh-workers@zsh.org
Cc: Oliver Kiddle <okiddle@yahoo.co.uk>
Subject: [PATCH 4/6] _baudrates: Fit better into the general completion framework
Date: Sun, 8 May 2016 00:09:14 +0200 [thread overview]
Message-ID: <1462658956-11785-5-git-send-email-ft@bewatermyfriend.org> (raw)
In-Reply-To: <1462658956-11785-1-git-send-email-ft@bewatermyfriend.org>
This should work better in concert with other helpers and builtins of
the completion system by accepting arguments that would be handed to
compadd.
---
Completion/Unix/Type/_baudrates | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/Completion/Unix/Type/_baudrates b/Completion/Unix/Type/_baudrates
index c6425f0..c1ee3f4 100644
--- a/Completion/Unix/Type/_baudrates
+++ b/Completion/Unix/Type/_baudrates
@@ -15,10 +15,6 @@
# value in the complete list to generate an arbitrary
# sub-set.
#
-# -t TAG Use TAG as the tag value in _wanted call.
-#
-# -d DESC Use DESC as the description value in _wanted call.
-#
# The default complete list of available baud rates is also configurable via
# the 'baud-rates' style:
#
@@ -31,11 +27,11 @@
# zstyle ':completion:*:*:screen:*' min-baud-rate 1200
# zstyle ':completion:*:*:screen:*' baud-rate-filter some_function_name
+local tmp
+local -a expl rates
local -A opts
-local expl tag desc tmp
-local -a rates
-zparseopts -E -A opts u: l: f: d: t:
+zparseopts -E -A opts u: l: f:
# The following uses a generated list; first find out where the B* macros are
# defined:
@@ -76,9 +72,7 @@ if (( ${+opts[-f]} )); then
done
fi
-tag=${opts[-t]:-baud-rate}
-desc=${opts[-d]:-baud rate}
-
# -1V removes dupes (which there shouldn't be) and otherwise leaves the
# order in the $rates array intact.
-_wanted -1V $tag expl $desc compadd -a $expl -- rates
+_description -1V baud-rates expl 'baud rate'
+compadd "${(@)argv/#-J/-V}" "$expl[@]" -- "${rates[@]}"
--
2.8.1
next prev parent reply other threads:[~2016-05-07 22:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 1:12 [PATCH] Add completion for picocom utility Frank Terbeck
2016-05-01 3:27 ` Ryan Wilson
2016-05-01 10:57 ` Frank Terbeck
2016-05-01 12:47 ` [PATCH] Refactor baud rate completion Frank Terbeck
2016-05-01 13:14 ` [PATCHv2] " Frank Terbeck
2016-05-01 13:27 ` [PATCHv3] " Frank Terbeck
2016-05-01 22:21 ` Frank Terbeck
2016-05-02 12:55 ` Oliver Kiddle
2016-05-03 21:01 ` Frank Terbeck
2016-05-07 21:53 ` Frank Terbeck
2016-05-11 15:08 ` Oliver Kiddle
2016-05-07 22:09 ` [PATCH 0/6] Update baud rate completion with Oliver's comments in mind Frank Terbeck
2016-05-07 22:09 ` [PATCH 1/6] _baudrate → _baudrates Frank Terbeck
2016-05-07 22:09 ` [PATCH 2/6] _baudrates: Use 2 space indentation Frank Terbeck
2016-05-07 22:53 ` Frank Terbeck
2016-05-07 22:09 ` [PATCH 3/6] Use _baudrates helper instead of _baudrate Frank Terbeck
2016-05-07 22:09 ` Frank Terbeck [this message]
2016-05-07 22:09 ` [PATCH 5/6] _cu: Remove old -d option of _baudrates Frank Terbeck
2016-05-07 22:09 ` [PATCH 6/6] _baudrates: Make style lookups fit better with the rest of compsys Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462658956-11785-5-git-send-email-ft@bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).