From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19580 invoked by alias); 25 Jun 2016 16:35:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38760 Received: (qmail 22257 invoked from network); 25 Jun 2016 16:35:05 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: [PATCH] _git-config: Stop trying to execute the empty string command name upon completing values for an unknown option. Date: Sat, 25 Jun 2016 16:34:58 +0000 Message-Id: <1466872498-6752-1-git-send-email-danielsh@tarsus.local2> X-Mailer: git-send-email 2.1.4 For example: % git config x.y.z +_git-config:834> case x.y.z (alias.*) +_git-config:834> case x.y.z (remotes.*) +_git-config:860> local z=$'\C-@' +_git-config:861> declare -a parts +_git-config:862> parts=( '' ) +_git-config:863> (( 1 < 2 )) +_git-config:863> [[ x.y.z == [^.]##.*.[^.]## ]] +_git-config:864> parts=( '' ) +_git-config:866> (( 1 > 0 )) +_git-config:867> case (-\>*) +_git-config:867> case (*) +_git-config:1197> declare -a action +_git-config:1198> _description values expl '' +_git-config:1199> eval 'action=()' +(eval):1> action=( ) +_git-config:1200> '' -J values _git-config:1200: permission denied: +_git-config:1206> return ret --- Completion/Unix/Command/_git | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 8bcdff3..2ef7a6d 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -2600,7 +2600,7 @@ _git-config () { if (( $#parts < 2 )) && [[ $line[1] == [^.]##.*.[^.]## ]]; then parts=("${(S@0)${git_options_static[(r)(#i)${line[1]%%.*}.\*.${line[1]##*.}:*]}//(#b)(*[^\\]|):/$match[1]$z}") fi - (( $#parts > 0 )) || return ret + (( $#parts >= 4 )) || return ret case $parts[4] in ('->'*) case ${parts[4]#->} in