From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: [PATCH] _postfix (postconf): Complete only applicable parameters for -X and -#.
Date: Wed, 14 Sep 2016 05:14:33 +0000 [thread overview]
Message-ID: <1473830073-331-1-git-send-email-danielsh@fujitsu.shahaf.local2> (raw)
---
One question about this patch:
% /usr/sbin/postconf -X <TAB>
zsh: do you wish to see all 112 possibilities (28 lines)?
I don't understand why it says "112". I expected it to say "32" since
my `postconf -n` output has 32 lines. Without this patch, it says
"928 possibilities", as expected, since my `postconf -d` output [what
the before-the-patch code uses] has 928 lines.
Why does it say 112 rather than 32?
Thanks,
Daniel
Completion/Unix/Command/_postfix | 34 ++++++++++++++++++++++++++++------
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/Completion/Unix/Command/_postfix b/Completion/Unix/Command/_postfix
index 528034e..afd56b7 100644
--- a/Completion/Unix/Command/_postfix
+++ b/Completion/Unix/Command/_postfix
@@ -16,11 +16,31 @@ _postfix_queue_id() {
compadd "$@" -- ${${${(M)lines:#(#s)[0-9bcdfghjklmnpqrstvwxyzBCDFGHJKLMNPQRSTVWXYZ](#c10)z*}%% *}%[*!]}
}
+# The first argument must be either 'd' or 'n', to complete parameters in
+# `postconf -d -H` or `postconf -n -H` output, respectively.
_postfix_main_cf_parameter() {
- local expl
- # Note for the future: if $mail_version >= 3.1, we can pass -H instead of
- # stripping the = signs by hand.
- _wanted parameters expl 'main.cf parameter' compadd "$@" -- ${${(f)"$(_call_program postconf-defaults "${(q)words[1]} -d")"}%% =*}
+ local -a expl
+ local kind
+
+ kind=$1; shift
+ case $kind in
+ (d)
+ # Note for the future: if $mail_version >= 3.1, we can pass -H instead of
+ # stripping the = signs by hand.
+ #
+ # don't bother to add -c in this case: the defaults don't depend on the config dir.
+ _wanted parameters expl 'main.cf parameter' compadd "$@" -- \
+ ${${(f)"$(_call_program postconf_-d "${(q)words[1]} -$kind")"}%% =*}
+ ;;
+ (n)
+ # Show the values too.
+ local -a kv=( ${${(f)"$(_call_program postconf_-n "${(q)words[1]} ${opt_args[-c]+"-c ${(q)opt_args[-c]}"} -$kind")"}/ = /:} )
+ _describe parameters kv
+ ;;
+ (*)
+ return 1 # can't happen due to the guard above
+ ;;
+ esac
}
_postfix_main_cf_parameter_and_value() {
@@ -33,7 +53,7 @@ _postfix_main_cf_parameter_and_value() {
local value="`_call_program postconf-get-value-at-dir "${(q)words[1]} ${opt_args[-c]+"-c ${(q)opt_args[-c]}"} -h -- ${(q)IPREFIX%=}"`"
[[ -n $value ]] && compadd "$@" -- $value
else
- _postfix_main_cf_parameter -S=
+ _postfix_main_cf_parameter d -S=
fi
}
@@ -130,8 +150,10 @@ case $service in
elif (( $+opt_args[-p] )); then
if (( $+opt_args[-e] )); then
_postfix_main_cf_parameter_and_value
+ elif [[ -n $opt_args[(i)(-X|-[#])] ]]; then
+ _postfix_main_cf_parameter n
else
- _postfix_main_cf_parameter
+ _postfix_main_cf_parameter d
fi
else # one of the master.cf modes: -M -F -P
_message "arguments for $opt_args[(i)${(j.|.)modes}] mode"
next reply other threads:[~2016-09-14 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 5:14 Daniel Shahaf [this message]
2016-09-14 16:46 ` Bart Schaefer
2016-09-15 2:15 ` Daniel Shahaf
2016-09-15 3:35 ` Bart Schaefer
2016-09-15 4:48 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473830073-331-1-git-send-email-danielsh@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).