From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: [PATCH] Fix unintentional history modifiers.
Date: Thu, 22 Sep 2016 11:43:17 +0000 [thread overview]
Message-ID: <1474544597-13684-1-git-send-email-danielsh@fujitsu.shahaf.local2> (raw)
---
The _dates one worked even before this patch (!); I haven't investigated why.
Daniel
Completion/Darwin/Type/_retrieve_mac_apps | 4 ++--
Completion/Unix/Command/_dsh | 2 +-
Completion/Unix/Type/_dates | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Completion/Darwin/Type/_retrieve_mac_apps b/Completion/Darwin/Type/_retrieve_mac_apps
index ba15577..f24d36c 100644
--- a/Completion/Darwin/Type/_retrieve_mac_apps
+++ b/Completion/Darwin/Type/_retrieve_mac_apps
@@ -71,7 +71,7 @@ _retrieve_mac_apps() {
# Get application search method
typeset retrieve
- if ! zstyle -s ":completion:*:*:$service:commands" search-method retrieve
+ if ! zstyle -s ":completion:*:*:${service}:commands" search-method retrieve
then
if [[ -d /.Spotlight-V100 ]]; then
# / is indexed to use Spotlight
@@ -80,7 +80,7 @@ _retrieve_mac_apps() {
# Fall back to the old way
retrieve=_mac_apps_old_retrieve
fi
- zstyle ":completion:*:*:$service:commands" search-method $retrieve
+ zstyle ":completion:*:*:${service}:commands" search-method $retrieve
fi
# Get root directories to search applications
diff --git a/Completion/Unix/Command/_dsh b/Completion/Unix/Command/_dsh
index 8c5c232..fc76800 100644
--- a/Completion/Unix/Command/_dsh
+++ b/Completion/Unix/Command/_dsh
@@ -25,7 +25,7 @@ _arguments -s -C -S \
'*::args: _normal' && return
if [[ $state = groups ]]; then
- if ! zstyle -s ":completion:$curcontext:dsh-groups" dsh-groups grp; then
+ if ! zstyle -s ":completion:${curcontext}:dsh-groups" dsh-groups grp; then
[[ -e ~/.dsh/group ]] && grp="~/.dsh/group" || return 1
fi
_path_files -W ~/.dsh/group && return
diff --git a/Completion/Unix/Type/_dates b/Completion/Unix/Type/_dates
index e4fa62e..0af10eb 100644
--- a/Completion/Unix/Type/_dates
+++ b/Completion/Unix/Type/_dates
@@ -22,10 +22,10 @@ local future mlabel mfmt mlabels
zparseopts -D -K -E f:=format F=future
(( future = $#future ? 1 : -1 ))
-zstyle -s ':completion:$curcontext:dates' date-format userformat
+zstyle -s ":completion:${curcontext}:dates" date-format userformat
format=${userformat:-${format[2]:-%F}}
-zstyle -a ':completion:$curcontext:dates' max-matches-length r
+zstyle -a ":completion:${curcontext}:dates" max-matches-length r
for ri in $r; do
[[ $ri = [0-9]##% ]] && (( ri = LINES * .${ri%%%} ))
(( ri < rows )) && (( rows=ri ))
next reply other threads:[~2016-09-22 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 11:43 Daniel Shahaf [this message]
2016-09-22 16:34 ` Bart Schaefer
2016-09-22 20:14 ` Daniel Shahaf
2016-09-22 20:46 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474544597-13684-1-git-send-email-danielsh@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).