From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Link error from latest CVS
Date: Mon, 08 Sep 2003 10:57:38 +0100 [thread overview]
Message-ID: <14783.1063015058@csr.com> (raw)
In-Reply-To: "Vin Shelton"'s message of "Sun, 07 Sep 2003 13:25:38 EDT." <m33cf8mrxp.fsf@zion.rcn.com>
Vin Shelton wrote:
> Peter,
>
> Using the latest sources from CVS, I cannot link. Here are the errors:
>
> Modules/parameter.o(.text+0x31b5): In function `setpmdisgalias':
> : undefined reference to `setgalias'
> Modules/parameter.o(.text+0x31e5): In function `setpmsalias':
> : undefined reference to `setgalias'
> Modules/parameter.o(.text+0x3215): In function `setpmdissalias':
> : undefined reference to `setgalias'
> collect2: ld returned 1 exit status
>
> Did you not check in part of your latest patch?
It was a typo; the lazy linkers I have didn't report it. It wasn't the
only typo, either, as I discovered when I tried assigning to saliases.
We need test scripts for the modules. To put it unambiguously, we need
someone to write test scripts for the modules.
Index: Src/Modules/parameter.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/parameter.c,v
retrieving revision 1.25
diff -u -r1.25 parameter.c
--- Src/Modules/parameter.c 3 Sep 2003 10:15:36 -0000 1.25
+++ Src/Modules/parameter.c 8 Sep 2003 09:54:51 -0000
@@ -1617,7 +1617,7 @@
static void
setalias(HashTable ht, Param pm, char *value, int flags)
{
- ht->addnode(aliastab, ztrdup(pm->nam),
+ ht->addnode(ht, ztrdup(pm->nam),
createaliasnode(value, flags));
}
@@ -1646,21 +1646,21 @@
static void
setpmdisgalias(Param pm, char *value)
{
- setgalias(aliastab, pm, value, ALIAS_GLOBAL|DISABLED);
+ setalias(aliastab, pm, value, ALIAS_GLOBAL|DISABLED);
}
/**/
static void
setpmsalias(Param pm, char *value)
{
- setgalias(sufaliastab, pm, value, 0);
+ setalias(sufaliastab, pm, value, ALIAS_SUFFIX);
}
/**/
static void
setpmdissalias(Param pm, char *value)
{
- setgalias(sufaliastab, pm, value, DISABLED);
+ setalias(sufaliastab, pm, value, ALIAS_SUFFIX|DISABLED);
}
/**/
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
prev parent reply other threads:[~2003-09-08 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-07 17:25 Vin Shelton
2003-09-08 9:57 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14783.1063015058@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).