From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27345 invoked by alias); 8 Nov 2016 07:20:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39864 Received: (qmail 20231 invoked from network); 8 Nov 2016 07:20:49 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(0.0/5.0):. Processed in 0.68697 secs); 08 Nov 2016 07:20:49 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=A9HN8QKsqhMZKvMWFGGE8ubE2L k=; b=wRcKhTonMs569Kmm4DEiqnIdbzCUornkwYviI+OBY35lCxnSWG43TyE6Y3 5Jldb3UREjansUlL9StuqUYwh9AVStKhjvJVlVsM0z6YyaqaZME24z4dGp+C/bv9 FKZml6+kkaGPUPCqvinPxTaFs49Or3ueoQs6wbKa+2xW30YL0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=A9 HN8QKsqhMZKvMWFGGE8ubE2Lk=; b=jwwhh2IHHfutp7x2HbK7ZqPVE8eQ9Zfb6w maxTXaf+Q9ObMyqVZsKmd9D5oyX9zjES5Ol9043K3ereeZKxrFSVul+Kro0BGgcB iLBFiujNB7oaJBKjQnS2x+EZFOaxDBhTSaNGEgyg5Kg9SUL8c5D30VMRMSszTx96 Bz2AdGNoA= X-ME-Sender: Message-Id: <1478588933.1740734.780806977.709688D0@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-d68eb56e References: <161107155001.ZM25685@torch.brasslantern.com> Date: Mon, 07 Nov 2016 23:08:53 -0800 In-Reply-To: <161107155001.ZM25685@torch.brasslantern.com> Subject: Re: Compiler warning after workers/39825 On Mon, Nov 7, 2016, at 03:50 PM, Bart Schaefer wrote: > ../../zsh-5.0/Src/utils.c: In function `mb_metastrlenend': > ../../zsh-5.0/Src/utils.c:5344: warning: comparison is always true due to > limited range of data type > > commit 9c68ef08 Probably an enlightenment is scheduled on this, but first rejecting-facts reaction is that you might have modified the line maybe? Why would char be always in 0 .. 0x7f is a mystery. Clang doesn't yield the warning. BTW. this can be optimized more: `!num_in_char` instead of `complete`, and no `num_in_char = 0` assignment. -- Sebastian Gniazdowski psprint@fastmail.com