From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2504 invoked by alias); 8 Nov 2016 08:36:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39866 Received: (qmail 2224 invoked from network); 8 Nov 2016 08:36:53 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(0.0/5.0):. Processed in 0.414469 secs); 08 Nov 2016 08:36:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=kPHesp8ZB4+2e15SSKP6v9AWtc I=; b=JUSRXcZDwfkRZMNRWVJz6t9Rgiie/58HMrb/AtsIJEsXToJy1QmHBYfaev ZMLWTsuaVaER32SoVBoghEqTXGsRyr1JzfLSbPo3YZ7C5VtsB3a3OrCJG5mk8V6u aLtpZ+NQu/FskFviYLpL0W+705EQfuvDeh5Om2OUfcVD79b/I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=kP Hesp8ZB4+2e15SSKP6v9AWtcI=; b=WWZHUV0CRvssfYm1q8XqsJ0lE1NN0w3/DJ BpnMazxUyPj9Hpw5Ll09qJ7WFEOvzjStqOK1HKlw8Bs6ot6YbpEvQSWujhW8Le2s 2GSy8AwWgQuK4j/DnalLRMpEACw/5YJyx78iYWiERzuWeKIzeZuir5QzrlAeJ7Sb QJBpE7pHw= X-ME-Sender: Message-Id: <1478594207.1754732.780857561.32F152A4@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_147859420717547324"; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-d68eb56e Date: Tue, 08 Nov 2016 00:36:47 -0800 References: <161107155001.ZM25685@torch.brasslantern.com> Subject: Re: Compiler warning after workers/39825 In-Reply-To: <161107155001.ZM25685@torch.brasslantern.com> --_----------=_147859420717547324 Content-Transfer-Encoding: 7bit Content-Type: text/plain On Mon, Nov 7, 2016, at 03:50 PM, Bart Schaefer wrote: > ../../zsh-5.0/Src/utils.c: In function `mb_metastrlenend': > ../../zsh-5.0/Src/utils.c:5344: warning: comparison is always true due to > limited range of data type > > commit 9c68ef08 Attached is patch that should work for both signed and unsigned integers. Does it emit any warning? On current system warmup the test results are 2141 ms vs 2337 ms, slightly less than 10%, but still ~200 ms difference. -- Sebastian Gniazdowski psprint@fastmail.com --_----------=_147859420717547324 Content-Disposition: attachment; filename="ascii_fix.diff" Content-Id: <1478594173.1754708.097012a8693a67130c3e7c963b0a217b916e03a8.32458AFB@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="ascii_fix.diff" ZGlmZiAtLWdpdCBhL1NyYy91dGlscy5jIGIvU3JjL3V0aWxzLmMKaW5kZXgg NzMzZjU3MC4uMzJlN2RjNiAxMDA2NDQKLS0tIGEvU3JjL3V0aWxzLmMKKysr IGIvU3JjL3V0aWxzLmMKQEAgLTUzNDEsNyArNTM0MSwxMiBAQCBtYl9tZXRh c3RybGVuZW5kKGNoYXIgKnB0ciwgaW50IHdpZHRoLCBjaGFyICplcHRyKQog CSAgICBpbmNoYXIgPSAqcHRyOwogCXB0cisrOwogCi0JaWYgKGNvbXBsZXRl ICYmIChpbmNoYXIgPj0gMCAmJiBpbmNoYXIgPD0gMHg3ZikpIHsKKyAgICAg ICAgLyoKKyAgICAgICAgICogMHg3ZiBpcyBhbGwgb25lcyBleGNlcHQgZm9y IHRvcCBiaXQgaW4gYmluYXJ5LAorICAgICAgICAgKiB0aGlzIHdpbGwgY2hl Y2sgaWYgaW5jaGFyIGlzIGluIHJhbmdlIDAgLi4gMTI3CisgICAgICAgICAq IGluY2x1c2l2ZSwgcmVnYXJkbGVzcyBvZiBjaGFyIHNpZ25lZG5lc3MKKyAg ICAgICAgICovCisJaWYgKGNvbXBsZXRlICYmIChpbmNoYXIgJiAweDdmKSA9 PSBpbmNoYXIpIHsKIAkgICAgLyoKIAkgICAgICogV2UgcmVseSBvbiA3LWJp dCBVUy1BU0NJSSBhcyBhIHN1YnNldCwgc28gc2tpcAogCSAgICAgKiBtdWx0 aWJ5dGUgaGFuZGxpbmcgaWYgd2UgaGF2ZSBzdWNoIGEgY2hhcmFjdGVyLgo= --_----------=_147859420717547324--