From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22931 invoked by alias); 8 Nov 2016 10:27:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39869 Received: (qmail 7626 invoked from network); 8 Nov 2016 10:27:10 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(0.0/5.0):. Processed in 0.431458 secs); 08 Nov 2016 10:27:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: |test1.zsh| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=y5hhYzUQQUSgTcNt2OmeKlffN/s=; b=pRpVQS4RkC73e6KSD8UhB tVbcqHZ0ZdJuK0Fvd0qDqcQdnHoiejZkJpW8tnsuDfRi4NB52lI2xeijiGGWJYFO rIDZEbdMshdUlxoaIMSg1/NoDY4llwlbH1Vppy5riCrpVrmh9Nq/zzERcDTJLSxt PzxQV4SUqebJHfCYxodG1Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=smtpout; bh=y5hhYzUQQUSgTcNt2OmeKlffN /s=; b=kq/mwnxJUsto+ACk6u1yqsri4ZBDZBzR4WkVul5kMa8uscOtvYgj1omMf uKF4dhPrizK8lsq2KfgObZU9fiyZkkcm4JRAt8SUK9Pxe4zCIJ6j7lgQrWCp3bKy FPVmO2ixVDsP/eyWRejI5fDLRif/Ygh+voYFawlqrHjJxcKzZU= X-ME-Sender: Message-Id: <1478600824.1774565.780940761.5A517B9E@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_147860082417745650"; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-d68eb56e Date: Tue, 08 Nov 2016 02:27:04 -0800 Subject: [PATCH] Mild setarrvalue() optimization --_----------=_147860082417745650 Content-Transfer-Encoding: 7bit Content-Type: text/plain Hello, there's freearray() at end of setarrvalue(). It can be replaced with free() if ownership of all strings will be given away: for (r = val; *r;) *p++ = ztrdup(*r++); becomes: for (r = val; *r;) *p++ = *r++; and freearray(val) -> free(val). It is very provable that this is correct: `val` must have data of the same kind as ztrdup() produces, as it is simply passed to freearray(), where zsfree() is called on each string. Test function: test_fun() { local -a arr arr=( "a" ) repeat 20; do arr+=( $arr ) done } Runs 2189 ms when no optimization, 1653 ms when optimized (when ran 3 times, test script attached). This is a mild optimization as most often short arrays are being assigned, not long like in the test function, but still, this can save one's day in certain situations. -- Sebastian Gniazdowski psprint@fastmail.com --_----------=_147860082417745650 Content-Disposition: attachment; filename="array_mild_opt.diff" Content-Id: <1478600634.1773958.041ac8f9b9378ddee2fc990335f9da994c3d71d2.3A55D25C@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="array_mild_opt.diff" ZGlmZiAtLWdpdCBhL1NyYy9wYXJhbXMuYyBiL1NyYy9wYXJhbXMuYwppbmRl eCAzMzBmMjJiLi41YTNlMGQzIDEwMDY0NAotLS0gYS9TcmMvcGFyYW1zLmMK KysrIGIvU3JjL3BhcmFtcy5jCkBAIC0yNjQ4LDE0ICsyNjQ4LDE4IEBAIHNl dGFycnZhbHVlKFZhbHVlIHYsIGNoYXIgKip2YWwpCiAJZm9yIChpID0gMDsg aSA8IHYtPnN0YXJ0OyBpKyspCiAJICAgICpwKysgPSBpIDwgcHJlX2Fzc2ln bm1lbnRfbGVuZ3RoID8genRyZHVwKCpxKyspIDogenRyZHVwKCIiKTsKIAlm b3IgKHIgPSB2YWw7ICpyOykKLQkgICAgKnArKyA9IHp0cmR1cCgqcisrKTsK KyAgICAgICAgICAgIC8qIEdpdmUgYXdheSBvd25lcnNoaXAgb2YgdGhlIHN0 cmluZyAqLworCSAgICAqcCsrID0gKnIrKzsKIAlpZiAodi0+ZW5kIDwgcHJl X2Fzc2lnbm1lbnRfbGVuZ3RoKQogCSAgICBmb3IgKHEgPSBvbGQgKyB2LT5l bmQ7ICpxOykKIAkJKnArKyA9IHp0cmR1cCgqcSsrKTsKIAkqcCA9IE5VTEw7 CiAKIAl2LT5wbS0+Z3N1LmEtPnNldGZuKHYtPnBtLCBuZXcpOwotCWZyZWVh cnJheSh2YWwpOworCisgICAgICAgIC8qIE93bmVyc2hpcCBvZiBhbGwgc3Ry aW5ncyBoYXMgYmVlbgorICAgICAgICAgKiBnaXZlbiBhd2F5LCBjYW4gcGxh aW5seSBmcmVlICovCisJZnJlZSh2YWwpOwogICAgIH0KIH0KIAo= --_----------=_147860082417745650 Content-Disposition: attachment; filename="test1.zsh" Content-Id: <1478600772.1774117.6e31071b217be957a726371d3bd42f75d93803bb.3E15983B@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="test1.zsh" IyEvdXNyL2xvY2FsL2Jpbi96c2gtYXJyc20tb3B0CiMhL3Vzci9sb2NhbC9i aW4venNoLWNsZWFuCgp6bW9kbG9hZCB6c2gvenByb2YKCnRlc3RfZnVuKCkg ewogICAgbG9jYWwgLWEgYXJyCiAgICBhcnI9KCAiYSIgKQogICAgcmVwZWF0 IDIwOyBkbwogICAgICAgIGFycis9KCAkYXJyICkKICAgIGRvbmUKfQoKdGVz dF9mdW4KdGVzdF9mdW4KdGVzdF9mdW4KCnpwcm9mCg== --_----------=_147860082417745650--