From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10646 invoked by alias); 8 Nov 2016 13:37:59 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39871 Received: (qmail 9863 invoked from network); 8 Nov 2016 13:37:58 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(0.0/5.0):. Processed in 0.389097 secs); 08 Nov 2016 13:37:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: |testopt2.zsh| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=UXcA+p9pLUl0BbuoV8PZE//4r0g=; b=PKBmuZN7nYcWmEBeBVz8w NwXypKr9rVBReM3CS/rMV1Rx3l7G9z2lk0+nVfA3nItpYjT21YAm1qBGZi5z7C7s R2rrlaRItMbgkC48gWQyfIM8FKTPhosVxv/gcWlkdudyGhjfNeoiuhdhEMZO4/J1 wgM20kS3TDIhDCG4hq1JR8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=smtpout; bh=UXcA+p9pLUl0BbuoV8PZE//4r 0g=; b=WiQTluWlvk4Y+EHUnrggGZ3ss00ODghp7R2SX5H0GhY6XMRZZInUOziQK KCGtCn7cF/eO/Ll2eDx3nTbvHesB44Mp5I9/JnD9013ES0jXENKn5kq7Y9pCVyDP AjCDllDQW0ZVtyvYhKz0RPFWfEhUGMWWvisfM5sHsLX6gjQelw= X-ME-Sender: Message-Id: <1478612273.1810945.781106353.1EF6BF52@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_147861227318109451"; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-d68eb56e Date: Tue, 08 Nov 2016 05:37:53 -0800 Subject: [PATCH] getstrvalue() optimization --_----------=_147861227318109451 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hello There are double strlen() invocations in getstrvalue(). It's not about negative indexes =E2=80=93=C2=A0although they have been optimized too =E2= =80=93=C2=A0but about dupstring() and v->end, v->start verification code at the end. Actually a single strlen() call is required. Attached test script runs 1765 ms for optimized Zsh, 1980 ms for no optimizations (minimum obtainable times): strtest() { a=3D"" i=3D$(( 4000 )) while (( i -- )); do a+=3D"a${a[1,200]}" done } I've used signed size variable but the code did that already. More optimization is possible =E2=80=93=C2=A0dupstring() could do strncpy(), cop= y only requested number of bytes, e.g. first 200 out of 10000, but the trailing \0 nuances made me wait with this change. --=20 Sebastian Gniazdowski psprint@fastmail.com --_----------=_147861227318109451 Content-Disposition: attachment; filename="string_opt.diff" Content-Id: <1478612149.1810520.f93798f5ccb0c67ce70bb9f45eed17bc3ef5c4a4.3427B355@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="string_opt.diff" ZGlmZiAtLWdpdCBhL1NyYy9wYXJhbXMuYyBiL1NyYy9wYXJhbXMuYwppbmRl eCAzMzBmMjJiLi41MDA1MDQyIDEwMDY0NAotLS0gYS9TcmMvcGFyYW1zLmMK KysrIGIvU3JjL3BhcmFtcy5jCkBAIC0yMDYwLDYgKzIwNjAsNyBAQCBnZXRz dHJ2YWx1ZShWYWx1ZSB2KQogewogICAgIGNoYXIgKnMsICoqc3M7CiAgICAg Y2hhciBidWZbQkRJR0JVRlNJWkVdOworICAgIGludCBsZW4gPSAtMTsKIAog ICAgIGlmICghdikKIAlyZXR1cm4gaGNhbGxvYygxKTsKQEAgLTIyMzcsMjIg KzIyMzgsMjYgQEAgZ2V0c3RydmFsdWUoVmFsdWUgdikKIAlyZXR1cm4gczsK IAogICAgIGlmICh2LT5zdGFydCA8IDApIHsKLQl2LT5zdGFydCArPSBzdHJs ZW4ocyk7CisJdi0+c3RhcnQgKz0gKGxlbj0oaW50KXN0cmxlbihzKSk7CiAJ aWYgKHYtPnN0YXJ0IDwgMCkKIAkgICAgdi0+c3RhcnQgPSAwOwogICAgIH0K ICAgICBpZiAodi0+ZW5kIDwgMCkgewotCXYtPmVuZCArPSBzdHJsZW4ocyk7 CisgICAgICAgIGxlbiA9IChsZW4gPj0gMCkgPyBsZW4gOiAoaW50KXN0cmxl bihzKTsKKwl2LT5lbmQgKz0gbGVuOwogCWlmICh2LT5lbmQgPj0gMCkgewog CSAgICBjaGFyICplcHRyID0gcyArIHYtPmVuZDsKIAkgICAgaWYgKCplcHRy KQogCQl2LT5lbmQgKz0gTUJfTUVUQUNIQVJMRU4oZXB0cik7CiAJfQogICAg IH0KLSAgICBzID0gKHYtPnN0YXJ0ID4gKGludClzdHJsZW4ocykpID8gZHVw c3RyaW5nKCIiKSA6IGR1cHN0cmluZyhzICsgdi0+c3RhcnQpOworCisgICAg bGVuID0gKGxlbiA+PSAwKSA/IGxlbiA6IChpbnQpc3RybGVuKHMpOworICAg IHMgPSAodi0+c3RhcnQgPiBsZW4pID8gZHVwc3RyaW5nKCIiKSA6IGR1cHN0 cmluZ193bGVuKHMgKyB2LT5zdGFydCwgbGVuIC0gdi0+c3RhcnQpOworCiAg ICAgaWYgKHYtPmVuZCA8PSB2LT5zdGFydCkKIAlzWzBdID0gJ1wwJzsKLSAg ICBlbHNlIGlmICh2LT5lbmQgLSB2LT5zdGFydCA8PSAoaW50KXN0cmxlbihz KSkKKyAgICBlbHNlIGlmICh2LT5lbmQgLSB2LT5zdGFydCA8PSBsZW4gLSB2 LT5zdGFydCkKIAlzW3YtPmVuZCAtIHYtPnN0YXJ0XSA9ICdcMCc7CiAKICAg ICByZXR1cm4gczsKZGlmZiAtLWdpdCBhL1NyYy9zdHJpbmcuYyBiL1NyYy9z dHJpbmcuYwppbmRleCAwNGU3NDQ2Li5iNDZlYTYwIDEwMDY0NAotLS0gYS9T cmMvc3RyaW5nLmMKKysrIGIvU3JjL3N0cmluZy5jCkBAIC00Myw2ICs0Mywx OSBAQCBkdXBzdHJpbmcoY29uc3QgY2hhciAqcykKIAogLyoqLwogbW9kX2V4 cG9ydCBjaGFyICoKK2R1cHN0cmluZ193bGVuKGNvbnN0IGNoYXIgKnMsIHVu c2lnbmVkIGxlbikKK3sKKyAgICBjaGFyICp0OworCisgICAgaWYgKCFzKQor CXJldHVybiBOVUxMOworICAgIHQgPSAoY2hhciAqKSB6aGFsbG9jKGxlbiAr IDEpOworICAgIHN0cmNweSh0LCBzKTsKKyAgICByZXR1cm4gdDsKK30KKwor LyoqLworbW9kX2V4cG9ydCBjaGFyICoKIHp0cmR1cChjb25zdCBjaGFyICpz KQogewogICAgIGNoYXIgKnQ7Cg== --_----------=_147861227318109451 Content-Disposition: attachment; filename="testopt2.zsh" Content-Id: <1478612156.1810520.94b7005eff9caebf7770397bb3fb756579e9722f.04BD291F@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="testopt2.zsh" IyFTcmMvenNoLW9wdDMKIyFTcmMvenNoLW5vLW9wdAojIVNyYy96c2gtb3B0 MgojIVNyYy96c2gtb3B0Cgp6bW9kbG9hZCB6c2gvenByb2YKCnN0cnRlc3Qo KSB7CiAgICBhPSIiCgogICAgaT0kKCggNDAwMCApKQogICAgd2hpbGUgKCgg aSAtLSApKTsgZG8KICAgICAgICBhKz0iYSR7YVsxLDIwMF19IgogICAgZG9u ZQp9CgpzdHJ0ZXN0Cgp6cHJvZiB8IGhlYWQgLW4gMjUK --_----------=_147861227318109451--