From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14451 invoked by alias); 8 Nov 2016 16:05:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39875 Received: (qmail 8708 invoked from network); 8 Nov 2016 16:05:10 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(0.0/5.0):. Processed in 0.492278 secs); 08 Nov 2016 16:05:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: |testopt4b.zsh| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=lGrKz8S+sFfeacVamoKtCtMJONM=; b=OI149jGMlshMKUyXwOaD0 fJp+VvHlqTHvgS+auQ/YciWiLrm59v1InFP3OkAZtbLUBH2Zpg4dYfKxL2HJBwJe GjgEY10P2PMuAzZehbQyqerjYZzNNVVE2JBMOKxtpKXOaqn5jPM2wUUYVsM/jAbB Cqw+6siMCcW+khfaJCZ2Ns= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=smtpout; bh=lGrKz8S+sFfeacVamoKtCtMJO NM=; b=W3+3Zd5Q7ENKBlgAnFSHTeGzXP4IJow/TJZNU11prsSZxTWB2i942oDN+ HmqQodoxFyomO56fOZ5jLRbfzCtxGqpenHLx1w49PLn/6g1VQgEodTDV8WS/JQno QRW8/86VB3ZqfuPJfGO1OvBwSXY7eFQRfdvv746yM0YENb44CE= X-ME-Sender: Message-Id: <1478621105.1844462.781280129.58937BB2@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_147862110518444620"; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-d68eb56e Date: Tue, 08 Nov 2016 08:05:05 -0800 Subject: [PATCH] assignstrvalue() optimization --_----------=_147862110518444620 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hello, patch is very simple =E2=80=93 utilizes dupstring's internal strlen to not = call strlen again outside. Following test function: strtest() { a=3D"" i=3D$(( 20000 )) while (( i -- )); do a+=3D"aaaaaaaaaaaaaaaaaaaaaaaaa" done } runs for 1511 ms with optimizations, 1829 ms with no optimizations. Changing to i=3D$(( 10000 )) gives times 364 ms 414 ms, 50 ms difference (minimum obtainable times). --=20 Sebastian Gniazdowski psprint@fastmail.com --_----------=_147862110518444620 Content-Disposition: attachment; filename="string_opt2.diff" Content-Id: <1478621029.1844315.c8ef551e603d142ece5d4b331375e876d00513e7.63CA79C9@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="string_opt2.diff" ZGlmZiAtLWdpdCBhL1NyYy9wYXJhbXMuYyBiL1NyYy9wYXJhbXMuYwppbmRl eCA1MDA1MDQyLi41ZmFiODRhIDEwMDY0NAotLS0gYS9TcmMvcGFyYW1zLmMK KysrIGIvU3JjL3BhcmFtcy5jCkBAIC0yNDI4LDggKzI0MjgsOCBAQCBhc3Np Z25zdHJ2YWx1ZShWYWx1ZSB2LCBjaGFyICp2YWwsIGludCBmbGFncykKIAkg ICAgY2hhciAqeiwgKng7CiAJICAgIGludCB6bGVuOwogCi0JICAgIHogPSBk dXBzdHJpbmcodi0+cG0tPmdzdS5zLT5nZXRmbih2LT5wbSkpOwotCSAgICB6 bGVuID0gc3RybGVuKHopOworCSAgICB6ID0gZHVwc3RyaW5nX2dsZW4odi0+ cG0tPmdzdS5zLT5nZXRmbih2LT5wbSksICh1bnNpZ25lZCopICZ6bGVuKTsK KwogCSAgICBpZiAoKHYtPmZsYWdzICYgVkFMRkxBR19JTlYpICYmIHVuc2V0 KEtTSEFSUkFZUykpCiAJCXYtPnN0YXJ0LS0sIHYtPmVuZC0tOwogCSAgICBp ZiAodi0+c3RhcnQgPCAwKSB7CmRpZmYgLS1naXQgYS9TcmMvc3RyaW5nLmMg Yi9TcmMvc3RyaW5nLmMKaW5kZXggYjQ2ZWE2MC4uY2UwY2Y1MSAxMDA2NDQK LS0tIGEvU3JjL3N0cmluZy5jCisrKyBiL1NyYy9zdHJpbmcuYwpAQCAtNTYs NiArNTYsMTkgQEAgZHVwc3RyaW5nX3dsZW4oY29uc3QgY2hhciAqcywgdW5z aWduZWQgbGVuKQogCiAvKiovCiBtb2RfZXhwb3J0IGNoYXIgKgorZHVwc3Ry aW5nX2dsZW4oY29uc3QgY2hhciAqcywgdW5zaWduZWQgKmxlbl9yZXQpCit7 CisgICAgY2hhciAqdDsKKworICAgIGlmICghcykKKwlyZXR1cm4gTlVMTDsK KyAgICB0ID0gKGNoYXIgKikgemhhbGxvYygoKmxlbl9yZXQgPSBzdHJsZW4o KGNoYXIgKilzKSkgKyAxKTsKKyAgICBzdHJjcHkodCwgcyk7CisgICAgcmV0 dXJuIHQ7Cit9CisKKy8qKi8KK21vZF9leHBvcnQgY2hhciAqCiB6dHJkdXAo Y29uc3QgY2hhciAqcykKIHsKICAgICBjaGFyICp0Owo= --_----------=_147862110518444620 Content-Disposition: attachment; filename="testopt4b.zsh" Content-Id: <1478621072.1844401.e124cbe891777a4d3f1cb30c10d8248acdabb314.7D207C7C@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="testopt4b.zsh" IyFTcmMvenNoLW9wdDQKIyFTcmMvenNoLW9wdDQtYmVmb3JlCgp6bW9kbG9h ZCB6c2gvenByb2YKCnN0cnRlc3QoKSB7CiAgICBhPSIiCgogICAgaT0kKCgg MjAwMDAgKSkKICAgIHdoaWxlICgoIGkgLS0gKSk7IGRvCiAgICAgICAgYSs9 ImFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWEiCiAgICBkb25lCn0KCnN0cnRl c3QKCnpwcm9mIHwgaGVhZCAtbiAyNQo= --_----------=_147862110518444620--