From: Sebastian Gniazdowski <psprint@fastmail.com>
To: zsh-workers@zsh.org
Subject: When is following code being run?
Date: Sat, 12 Nov 2016 02:23:04 -0800 [thread overview]
Message-ID: <1478946184.2939151.785456169.516647E1@webmail.messagingengine.com> (raw)
Hello,
file params.c, line 1572 and following in the else block:
https://github.com/zsh-users/zsh/blob/master/Src/params.c#L1572-L1583
The strlen can be optimized out, as getstrvalue has most probably ran it
already. I wonder about benefits, as there will be probably none, as "
if (pprog && pattry(pprog, d) &&" and similar code consumes probably 95%
of CPU cycles. But would test this, who knows.
--
Sebastian Gniazdowski
psprint@fastmail.com
next reply other threads:[~2016-11-12 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 10:23 Sebastian Gniazdowski [this message]
2016-11-12 11:40 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478946184.2939151.785456169.516647E1@webmail.messagingengine.com \
--to=psprint@fastmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).