From: Sebastian Gniazdowski <psprint@fastmail.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Optimization of getarrvalue()
Date: Tue, 15 Nov 2016 23:55:03 -0800 [thread overview]
Message-ID: <1479282903.662420.789349689.2C59B522@webmail.messagingengine.com> (raw)
In-Reply-To: <161114091036.ZM22821@torch.brasslantern.com>
On Mon, Nov 14, 2016, at 09:10 AM, Bart Schaefer wrote:
> The original code structure was
>
> if (A)
> a;
> else
> x;
> if (B)
> b;
> else if (C)
> c;
>
...
> This means that in the new structure, b never happens when A. In the
> old code we might allocate the array ('') and then truncate to (), but
> in the new code we allocate ('') and then do nothing.
I was aware of nular being something different because tests failed
(it's an easy thing to find though, but I chosen to signal problem
instead of solving it), however as the two if blocks are not connected
with else, nular can be, as you said, "again" truncated to 0 length.
That I didn't foresee.
--
Sebastian Gniazdowski
psprint@fastmail.com
next prev parent reply other threads:[~2016-11-16 8:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161108201233epcas1p1e2900e2d67af8b8558ebdb70eb7ad480@epcas1p1.samsung.com>
2016-11-08 20:11 ` Sebastian Gniazdowski
2016-11-08 21:58 ` Bart Schaefer
2016-11-09 7:11 ` Bart Schaefer
2016-11-09 11:42 ` Peter Stephenson
2016-11-09 16:03 ` Bart Schaefer
2016-11-14 12:32 ` Jun T.
2016-11-14 13:15 ` Jun T.
2016-11-14 13:57 ` Peter Stephenson
2016-11-14 15:35 ` Jun T.
2016-11-14 17:10 ` Bart Schaefer
2016-11-16 7:55 ` Sebastian Gniazdowski [this message]
2016-11-15 12:28 ` Peter Stephenson
2016-11-15 19:57 ` Peter Stephenson
2016-11-15 21:11 ` Bart Schaefer
2016-11-16 14:06 ` Jun T.
2016-11-16 16:14 ` Jun T.
2016-11-16 18:50 ` Bart Schaefer
2016-11-21 12:30 ` Jun T.
2016-11-24 0:55 ` Bart Schaefer
2016-11-24 11:49 ` Jun T.
2016-11-29 6:11 ` Array slices that don't exist [was Optimization of getarrvalue()] Bart Schaefer
2016-11-29 9:34 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479282903.662420.789349689.2C59B522@webmail.messagingengine.com \
--to=psprint@fastmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).