From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19590 invoked by alias); 18 Nov 2016 09:32:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39973 Received: (qmail 10945 invoked from network); 18 Nov 2016 09:32:28 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(-0.7/5.0):. Processed in 1.198652 secs); 18 Nov 2016 09:32:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: |testopt7.zsh| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rmJne7POCKw6sYptdhyUS8bYpm w=; b=lYvEqyOR0fJuVuWVP/+dKLXIVQVnUef10u0Rm7Cb93QkjV+9e7HpAsTUzN QDT5Dallx29whC7ilvB9AU54r8g4P8/Fmnn+fFl89XtvJdLZip8o1Nivnhrev99W TLzgMybNgQqq4TkbTgpuUXlVgusP7FccidseOW+Ct1rbu3VtA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=rm Jne7POCKw6sYptdhyUS8bYpmw=; b=sik9rxOMauPHn0HmsD82RXX+dWSWe2v8bh yIO4sDH8XGkHVBcW+s6bxOrKU9BYNIEVvclOGZEb/bqJW1Joe4DH6LZUpi4QK/yt +YXPjQVipB4trbDW2wodmQ4BMzKs42o6Rmb72yY7RBY5Ph59/e80qc6cbxMhsuO+ QwXKDauOY= X-ME-Sender: Message-Id: <1479461540.1340250.791913609.27FAD722@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_147946154013402500" X-Mailer: MessagingEngine.com Webmail Interface - ajax-461bce03 References: <1479449829.1305485.791811385.14DDFE28@webmail.messagingengine.com> In-Reply-To: <1479449829.1305485.791811385.14DDFE28@webmail.messagingengine.com> Date: Fri, 18 Nov 2016 01:32:20 -0800 Subject: Re: Possible huge setarrvalue optimization --_----------=_147946154013402500 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hello, I attach patch that needs one problem to be resolved. Gains for following test code: test_fun() { arr[20000]=3D"" repeat 10000; do arr[10000]=3D"x" done } are huge: 37969 ms with no optimization, 244 ms with optimization. The screensaver runs for 495 sec without optimization, 51 sec with opt (still slower than hash which runs for 23 sec). I changed: if (v->end <=3D pre_assignment_length) post_assignment_length +=3D pre_assignment_length - v->end + 1; to: if (v->end <=3D pre_assignment_length) post_assignment_length +=3D pre_assignment_length - v->end; And this allows to test post* =3D=3D pre*. I think the "+ 1" isn't needed, v->end can be treated as "number of elements affected already". Subtracting the number of elements from pre_assignment_length gives correct value: elements that will be copied from old. The thing that has to be resolved: special setters. The patch contains one special handler tested: if ( pre_assignment_length !=3D post_assignment_length || v->pm->gsu.a->setfn =3D=3D set_region_active ) { But this doesn't work as the symbol `set_region_active` isn't available. How to solve this, and what are other special handlers? One test is failing (A06) =E2=80=93 append to typeset -U array, because the special set= ter isn't called. --=20 Sebastian Gniazdowski psprint@fastmail.com --_----------=_147946154013402500 Content-Disposition: attachment; filename="array_big_opt.diff" Content-Id: <1479460580.1337878.003d9cc2d8be3c83da5fa3703dd3ee841368c51b.3A831EF3@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="array_big_opt.diff" ZGlmZiAtLWdpdCBhL1NyYy9wYXJhbXMuYyBiL1NyYy9wYXJhbXMuYwppbmRl eCBlZjcyY2JhLi5lMjNhMGFmIDEwMDY0NAotLS0gYS9TcmMvcGFyYW1zLmMK KysrIGIvU3JjL3BhcmFtcy5jCkBAIC0yNjU0LDI0ICsyNjU0LDM0IEBAIHNl dGFycnZhbHVlKFZhbHVlIHYsIGNoYXIgKip2YWwpCiAJICAgIHYtPmVuZCA9 IHYtPnN0YXJ0OwogCiAJcG9zdF9hc3NpZ25tZW50X2xlbmd0aCA9IHYtPnN0 YXJ0ICsgYXJybGVuKHZhbCk7Ci0JaWYgKHYtPmVuZCA8PSBwcmVfYXNzaWdu bWVudF9sZW5ndGgpCi0JICAgIHBvc3RfYXNzaWdubWVudF9sZW5ndGggKz0g cHJlX2Fzc2lnbm1lbnRfbGVuZ3RoIC0gdi0+ZW5kICsgMTsKLQotCXAgPSBu ZXcgPSAoY2hhciAqKikgenNoY2FsbG9jKHNpemVvZihjaGFyICopCi0JCSAg ICAgICAgICAgICAgICAgICAgICAqIChwb3N0X2Fzc2lnbm1lbnRfbGVuZ3Ro ICsgMSkpOwotCi0JZm9yIChpID0gMDsgaSA8IHYtPnN0YXJ0OyBpKyspCi0J ICAgICpwKysgPSBpIDwgcHJlX2Fzc2lnbm1lbnRfbGVuZ3RoID8genRyZHVw KCpxKyspIDogenRyZHVwKCIiKTsKLQlmb3IgKHIgPSB2YWw7ICpyOykgewot ICAgICAgICAgICAgLyogR2l2ZSBhd2F5IG93bmVyc2hpcCBvZiB0aGUgc3Ry aW5nICovCi0JICAgICpwKysgPSAqcisrOwotCX0KLQlpZiAodi0+ZW5kIDwg cHJlX2Fzc2lnbm1lbnRfbGVuZ3RoKQotCSAgICBmb3IgKHEgPSBvbGQgKyB2 LT5lbmQ7ICpxOykKLQkJKnArKyA9IHp0cmR1cCgqcSsrKTsKLQkqcCA9IE5V TEw7CiAKLQl2LT5wbS0+Z3N1LmEtPnNldGZuKHYtPnBtLCBuZXcpOworCWlm ICh2LT5lbmQgPD0gcHJlX2Fzc2lnbm1lbnRfbGVuZ3RoKQorCSAgICBwb3N0 X2Fzc2lnbm1lbnRfbGVuZ3RoICs9IHByZV9hc3NpZ25tZW50X2xlbmd0aCAt IHYtPmVuZDsKKworICAgICAgICBpZiAoIHByZV9hc3NpZ25tZW50X2xlbmd0 aCAhPSBwb3N0X2Fzc2lnbm1lbnRfbGVuZ3RoIHx8IHYtPnBtLT5nc3UuYS0+ c2V0Zm4gPT0gc2V0X3JlZ2lvbl9hY3RpdmUgKSB7CisgICAgICAgICAgICBw ID0gbmV3ID0gKGNoYXIgKiopIHpzaGNhbGxvYyhzaXplb2YoY2hhciAqKQor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKiAo cG9zdF9hc3NpZ25tZW50X2xlbmd0aCArIDEpKTsKKworICAgICAgICAgICAg Zm9yIChpID0gMDsgaSA8IHYtPnN0YXJ0OyBpKyspCisgICAgICAgICAgICAg ICAgKnArKyA9IGkgPCBwcmVfYXNzaWdubWVudF9sZW5ndGggPyB6dHJkdXAo KnErKykgOiB6dHJkdXAoIiIpOworICAgICAgICAgICAgZm9yIChyID0gdmFs OyAqcjspIHsKKyAgICAgICAgICAgICAgICAvKiBHaXZlIGF3YXkgb3duZXJz aGlwIG9mIHRoZSBzdHJpbmcgKi8KKyAgICAgICAgICAgICAgICAqcCsrID0g KnIrKzsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGlmICh2LT5lbmQg PCBwcmVfYXNzaWdubWVudF9sZW5ndGgpCisgICAgICAgICAgICAgICAgZm9y IChxID0gb2xkICsgdi0+ZW5kOyAqcTspCisgICAgICAgICAgICAgICAgICAg ICpwKysgPSB6dHJkdXAoKnErKyk7CisgICAgICAgICAgICAqcCA9IE5VTEw7 CisKKyAgICAgICAgICAgIHYtPnBtLT5nc3UuYS0+c2V0Zm4odi0+cG0sIG5l dyk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvKiB2LT5zdGFy dCBpcyAwLWJhc2VkICovCisgICAgICAgICAgICBwID0gb2xkICsgdi0+c3Rh cnQ7CisgICAgICAgICAgICBmb3IgKHIgPSB2YWw7ICpyOykgeworICAgICAg ICAgICAgICAgIC8qIEdpdmUgYXdheSBvd25lcnNoaXAgb2YgdGhlIHN0cmlu ZyAqLworICAgICAgICAgICAgICAgICpwKysgPSAqcisrOworICAgICAgICAg ICAgfQorICAgICAgICB9CiAKICAgICAgICAgLyogT3duZXJzaGlwIG9mIGFs bCBzdHJpbmdzIGhhcyBiZWVuCiAgICAgICAgICAqIGdpdmVuIGF3YXksIGNh biBwbGFpbmx5IGZyZWUgKi8K --_----------=_147946154013402500 Content-Disposition: attachment; filename="testopt7.zsh" Content-Id: <1479461347.1339601.e8500ba2ec0e4e1e4c7f7e8fd2d0541cd1834cca.1B52F80C@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; name="testopt7.zsh" IyEvdXNyL2xvY2FsL2Jpbi96c2gtYXJyLWFzc2lnbgojIS91c3IvbG9jYWwv YmluL3pzaC1hcnItYXNzaWduLWJlZm9yZQoKem1vZGxvYWQgenNoL3pwcm9m Cgp0eXBlc2V0IC1hIGFycgoKdGVzdF9mdW4oKSB7CiAgICBhcnJbMjAwMDBd PSIiCiAgICByZXBlYXQgMTAwMDA7IGRvCiAgICAgICAgYXJyWzEwMDAwXT0i eCIKICAgIGRvbmUKfQoKdGVzdF9mdW4KCnByaW50IC1ybCAkYXJyW0BdICRh cnJbMTAwMDBdCgp6cHJvZgo= --_----------=_147946154013402500--