From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19928 invoked by alias); 20 Nov 2016 20:54:50 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39997 Received: (qmail 24787 invoked from network); 20 Nov 2016 20:54:50 -0000 X-Qmail-Scanner-Diagnostics: from new2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.224):SA:0(-0.7/5.0):. Processed in 0.7732 secs); 20 Nov 2016 20:54:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_LOW,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint@fastmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.224 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=SBnDCddaEgziA6K725uq/1ZtYT A=; b=ZSZ/Kg8LRLUzVKp6UGg20SwEWUU9BQHQpYraPknZs3jZrH+EsdNIpyWxOZ pVO6935e4mWZB54P8bmFfr7+gwiuS85Y9DTKOXv+m2Fl3UXvIbEfAwetVsYbFVBF yc+3AZlinUICus9/0VXUdPkqPE0Po3wCjrEC9AljAXc/As8+M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=SB nDCddaEgziA6K725uq/1ZtYTA=; b=lIMBwXMTm1VirhhcJw2UUrqWz1EpQ3H7bt RXAng0iPrPGrOAIs82FhQxhJdfeSkrQ4GdiGxCTxZkduBm5A75ewF5n7FNAxvyPp pc0iSdgEXsHQJPhbn1bU9TWHss6YGGcpEOVtjKZJa6lpnJZdw3xCMlr+4YMuem8j a8oiF3qU0= X-ME-Sender: Message-Id: <1479675281.2839405.793887953.7970D606@webmail.messagingengine.com> From: Sebastian Gniazdowski To: Bart Schaefer Cc: Zsh hackers list MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/alternative; boundary="_----------=_147967528128394050" X-Mailer: MessagingEngine.com Webmail Interface - ajax-461bce03 Subject: Re: Possible huge setarrvalue optimization References: <1479449829.1305485.791811385.14DDFE28@webmail.messagingengine.com> <1479461540.1340250.791913609.27FAD722@webmail.messagingengine.com> <1479471620.1371132.792049209.295BE093@webmail.messagingengine.com> <20161120114648.GA6953@fujitsu.shahaf.local2> Date: Sun, 20 Nov 2016 12:54:41 -0800 In-Reply-To: --_----------=_147967528128394050 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Sun, Nov 20, 2016, at 09:41 AM, Bart Schaefer wrote: > Thanks for pointing out those possible details. I know from > implementing the param_private module that this part of the code is > really important to assumptions made downstream -- it may appear safe > to "give away" strings based on local examination here but in fact > cause problems outside this function. > This and the proposed getstr optimization both make me nervous. I > know Sebastian is anxious to have them appear in the next release, but > it feels and if we should have more time using them in dev branches. Not much problem to not see this in 5.3, my code doesn't benefit much, however it's a very cool thing that allows to do typeset -a arr; arr[max_size] =3D 2000, and then freely write to not reallocated array =E2= =80=93 really, arrays of size 5000 are unusable without the patch when storing to single fields, times are too large. I counted on feedback about what might break, was from some time aware of the ename, curiously tied arrays/scalars work fine, but the environment fixing on not empty ename is a problem. Best regards, Sebastian Gniazdowski --_----------=_147967528128394050--