From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12337 invoked by alias); 16 Feb 2017 16:25:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40559 Received: (qmail 26068 invoked from network); 16 Feb 2017 16:25:28 -0000 X-Qmail-Scanner-Diagnostics: from new1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.221):SA:0(-0.4/5.0):. Processed in 1.05074 secs); 16 Feb 2017 16:25:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint2@fastmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.221 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cH3oln/eDPvJASIXZ8ulJeOZ9l M=; b=jvjUtcryZHLRMgS03cd71sp1uqsw+uzf2Iq+zbN/gboB05VhHFb3k/dl3H 5Aj4KUQrFKiYEF8pxsXksCoUMU7uMFffWisEdj7gwt69RtofhAVnXvl6kkVtICYO 7NYtOP3Et0TSS6R4lKK6oZUoXIwObyFJ7jvvi9iAaGKmt1Mus= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=cH 3oln/eDPvJASIXZ8ulJeOZ9lM=; b=bskNku5UK+lR5cMLkdHyFMI7bCkX7LKNfp TfYWtBsDGRiRL5uOK8RBUT0wqE+kxmsjFpq4WGWQD6SaOuYmNk+rzPtDXXH0si9A 7LXUm3tJa1+WUY125Nobj+52RbskcAo5g0e/Rcg0gVfJcbiJPDyGr3/H60x5boJR 0L/Ca14I4= X-ME-Sender: Message-Id: <1487262324.1911841.883231656.222E231A@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-7cfc9722 Subject: Re: [PATCH] db/gdbm rewrite In-Reply-To: <1487261017.1907093.883202288.270632CF@webmail.messagingengine.com> Date: Thu, 16 Feb 2017 08:25:24 -0800 References: <1487074831.317363.880495280.04595B08@webmail.messagingengine.com> <1487154163.615323.881647656.040AB25F@webmail.messagingengine.com> <20170216101658.46555c47@pwslap01u.europe.root.pri> <1487245575.1843244.882932424.59844A89@webmail.messagingengine.com> <20170216125215.1b744bf6@pwslap01u.europe.root.pri> <1487255103.1880827.883083384.73295E85@webmail.messagingengine.com> <1487255450.1882152.883095336.5DDBE902@webmail.messagingengine.com> <20170216151152.0f5a07ef@pwslap01u.europe.root.pri> <1487261017.1907093.883202288.270632CF@webmail.messagingengine.com> On Thu, Feb 16, 2017, at 08:03 AM, Sebastian Gniazdowski wrote: > On Thu, Feb 16, 2017, at 07:11 AM, Peter Stephenson wrote: > > % zmodload zsh/db/gdbm > > % ztie -d db/gdbm -f db.gdbm dbase > > % dbase[testkey]=somewhat > > ==25034== Invalid write of size 1 > > ==25034== at 0x80E0B78: metafy (utils.c:4652) > > I've used HEAP_ALLOC instead of HEAP_DUP in argument for metafy. Fixing > this resolves valgrind report. Important catch.. Hopefully it will > resolve enable-zsh-mem problem (I cannot reproduce that). Sending as > complete patch plus db_gdbm.c file. Yeah this will fix the problem. I did: pm->u.str = metafy(content.dptr, content.dsize, META_ALLOC); There were no meta characters so metafy() didn't allocate memory, returned internal GDBM pointer. META_DUP always allocates. Thanks! -- Sebastian Gniazdowski psprint2@fastmail.com