zsh-workers
 help / color / mirror / code / Atom feed
From: Sebastian Gniazdowski <psprint2@fastmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>, zsh-workers@zsh.org
Subject: Re: Closing descriptors in forked (pipe) command
Date: Sun, 19 Feb 2017 00:04:38 -0800	[thread overview]
Message-ID: <1487491478.281773.885668344.1F5A7E47@webmail.messagingengine.com> (raw)
In-Reply-To: <170218210200.ZM27007@torch.brasslantern.com>

On Sat, Feb 18, 2017, at 09:02 PM, Bart Schaefer wrote:
> On Feb 18,  4:45am, Sebastian Gniazdowski wrote:
> }
> } in db/gdbm module, I do:
> }         addmodulefd(gdbm_fdesc(dbf), FDT_MODULE);
> } 
> } The point is: forked process inherits database connection. GDBM cannot
> } have multiple writers (open is in write mode).
> 
> That's not true -- "man gdbm" even mentions:
> 
>    If  the  database  was  opened with the GDBM_NOLOCK flag, the user may
>    wish to perform their own file locking on the database file  in  order
>    to prevent multiple writers operating on the same file simultaneously.

This would make GDBM quite standout, except I probably superficially
interpreted what I was reading. My opinion about GDBM comes from the
fact that I cannot have reader + writer with gdbmtool, i.e. run once
"gdbmtool -r db", then "gdbmtool db" – first program will stop working:

stdin:1.5: cannot open db: Can't be reader

The superficial reading was one other DBM database that was stating
boldly about no simultaneous access, but I think it was also stating
that multiple threads are possible. Sorry cannot find that again. But
this would reveal that it can be about proper locking, not simultaneous
access itself. Either way GDBM has nice potential but I might not be
able to leverage it in the module. Fast ztie, hash scan, untie is quite
much as custom locking & unlocking to access database.

> } Maybe it would be good to solve this? FDT_FORKCLOSE or something, there
> } is closeallelse(), for multiio, didn't go deeper in this.
> 
> In the general case a subshell should be inheriting all descriptors from
> the parent, and it's up to the shell programmer not to do stupid things.
> Consider the case where the parent shell wishes to ztie to the database,
> fork off a subshell that will make use of the tied parameter, and then
> go on to exec something else or otherwise exit, leaving the subshell to
> manage the database.

Ok, with file position pointer sanity, and "file has changed" sanity of
GDBM, this is in quite good state and the use case you wrote is
available to the user.

-- 
Sebastian Gniazdowski


  reply	other threads:[~2017-02-19  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 12:45 Sebastian Gniazdowski
2017-02-19  5:02 ` Bart Schaefer
2017-02-19  8:04   ` Sebastian Gniazdowski [this message]
2017-02-19 10:51   ` [PATCH] " Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487491478.281773.885668344.1F5A7E47@webmail.messagingengine.com \
    --to=psprint2@fastmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).