From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17992 invoked by alias); 7 Mar 2017 06:50:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40782 Received: (qmail 7723 invoked from network); 7 Mar 2017 06:50:25 -0000 X-Qmail-Scanner-Diagnostics: from new1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.221):SA:0(-0.4/5.0):. Processed in 2.113995 secs); 07 Mar 2017 06:50:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: psprint3@fastmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at spf.messagingengine.com designates 66.111.4.221 as permitted sender) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ki74GKq2854pkSGfGJd2mv06SV I=; b=VY2z9iyhWtsHm6sanU2fF+w1ne2xvsZaokgIC+xAs4vbsIJq3Qd0LhITkd 1t6PhD5paqkwayFsnZk2jacdExM17VMKbmKfQDSl/q1CsgPyAWcmXmfE5ac5YKnK M8BggyTgqQEyHZYcLEE/BgW3kglJy0TdOgxkgYM4hEaBKFoK0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=smtpout; bh=ki 74GKq2854pkSGfGJd2mv06SVI=; b=jwltJCGbBVDW9pHO+rKcbYOnZ9PK9Dh9zj uAUq/e7hTTcrW4XYAFbsUFezvwLM04szpVpJCAZ2c1Fzqw5bnvU0OtdRTzlCv2sW k/8uJomx2zbmdxMcANg77Z67tRk6ccY//sX45epK47ceuOWMOq7wdLfBmU43SnDd gaACJ+NHM= X-ME-Sender: Message-Id: <1488869415.4132903.902877024.7D41352B@webmail.messagingengine.com> From: Sebastian Gniazdowski To: zsh-workers@zsh.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_148886941541329031" X-Mailer: MessagingEngine.com Webmail Interface - ajax-9f47d516 Date: Mon, 06 Mar 2017 22:50:15 -0800 In-Reply-To: <20170307021849.11740-1-mikachu@gmail.com> References: <20170307021849.11740-1-mikachu@gmail.com> Subject: Re: PATCH: Don't use =~ for simple prefix match --_----------=_148886941541329031 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" On Mon, Mar 6, 2017, at 06:18 PM, Mikael Magnusson wrote: > - if [[ "${OSTYPE}" =~ freebsd.* ]]; then > + if [[ "${OSTYPE}" = freebsd* ]]; then Did similar for _hosts: - elif [[ $host =~ "\[(.*)\]:\d*" ]]; then - khosts+=$match + elif [[ $host = (#b)*\[(*)\]:[[:digit:]]#* ]]; then + khosts+=${match[1]} Also localized match parameters. Had to add wrapping stars because =~ matches substrings. -- Sebastian Gniazdowski psprint3@fastmail.com --_----------=_148886941541329031 Content-Disposition: attachment; filename="hosts_no_regex.diff" Content-Id: <1488869328.4131567.2d11322b0a42b175ed5f242cd63ed8a86e0eb0ef.0D04E35C@content.messagingengine.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; name="hosts_no_regex.diff" ZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vVW5peC9UeXBlL19ob3N0cyBiL0Nv bXBsZXRpb24vVW5peC9UeXBlL19ob3N0cwppbmRleCA1NjU0MDg2Li5kOWUx MDkwIDEwMDY0NAotLS0gYS9Db21wbGV0aW9uL1VuaXgvVHlwZS9faG9zdHMK KysrIGIvQ29tcGxldGlvbi9Vbml4L1R5cGUvX2hvc3RzCkBAIC01MCwxMiAr NTAsMTMgQEAgaWYgISB6c3R5bGUgLWEgIjpjb21wbGV0aW9uOiR7Y3VyY29u dGV4dH06aG9zdHMiIGhvc3RzIF9ob3N0czsgdGhlbgogICAgICAgICAjIGVu dHJpZXMuCiAgICAgICAgICgpIHsKICAgICAgICAgICBsb2NhbCBob3N0Cisg ICAgICAgICAgbG9jYWwgLWEgbWF0Y2ggbWJlZ2luIG1lbmQKICAgICAgICAg ICBraG9zdHM9KCkKICAgICAgICAgICBmb3IgaG9zdDsgZG8KICAgICAgICAg ICAgIGlmIFtbICRob3N0ID09ICpbKj9dKiBdXTsgdGhlbgogICAgICAgICAg ICAgICBjb250aW51ZQotICAgICAgICAgICAgZWxpZiBbWyAkaG9zdCA9fiAi XFsoLiopXF06XGQqIiBdXTsgdGhlbgotICAgICAgICAgICAgICBraG9zdHMr PSRtYXRjaAorICAgICAgICAgICAgZWxpZiBbWyAkaG9zdCA9ICgjYikqXFso KilcXTpbWzpkaWdpdDpdXSMqIF1dOyB0aGVuCisgICAgICAgICAgICAgIGto b3N0cys9JHttYXRjaFsxXX0KICAgICAgICAgICAgIGVsc2UKICAgICAgICAg ICAgICAga2hvc3RzKz0kaG9zdAogICAgICAgICAgICAgZmkK --_----------=_148886941541329031--