From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: PATCH: Restore `LC_ALL' when setting `LANG'
Date: Fri, 6 Jan 2012 15:03:54 +0900 [thread overview]
Message-ID: <1490C10C-33CA-4A1F-8579-066B77773A40@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20120104173017.3b10a803@pws-pc.ntlworld.com>
Instead of adding LC_ALL to lc_names[], I think it better
not calling setlocale() at all if LC_ALL is non-empty.
Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.175
diff -u -r1.175 params.c
--- Src/params.c 11 Aug 2011 19:32:50 -0000 1.175
+++ Src/params.c 6 Jan 2012 05:42:12 -0000
@@ -3788,6 +3788,10 @@
setlang(char *x)
{
struct localename *ln;
+ char *x2;
+
+ if ((x2 = getsparam("LC_ALL")) && *x2)
+ return;
/*
* Set the global locale to the value passed, but override
next prev parent reply other threads:[~2012-01-07 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120102132718.GA12143@gatsby.mbjnet.dk>
[not found] ` <87fwfyb2if.fsf@ft.bewatermyfriend.org>
[not found] ` <20120102154714.GA20663@gatsby.mbjnet.dk>
[not found] ` <87wr9a9ely.fsf@ft.bewatermyfriend.org>
[not found] ` <20120103111049.GA5673@gatsby.mbjnet.dk>
[not found] ` <87sjjw98yl.fsf@ft.bewatermyfriend.org>
[not found] ` <87k458974e.fsf@ft.bewatermyfriend.org>
[not found] ` <2012-01-03T15-59-18@devnull.michael-prokop.at>
[not found] ` <87boqk95we.fsf@ft.bewatermyfriend.org>
2012-01-03 15:26 ` Frank Terbeck
2012-01-04 2:16 ` Vincent Lefevre
2012-01-04 17:30 ` Peter Stephenson
2012-01-06 6:03 ` Jun T. [this message]
2012-01-07 20:04 ` Peter Stephenson
2012-01-07 21:41 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490C10C-33CA-4A1F-8579-066B77773A40@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).