From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6531 invoked by alias); 12 Jun 2017 14:46:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41273 Received: (qmail 13121 invoked from network); 12 Jun 2017 14:46:05 -0000 X-Qmail-Scanner-Diagnostics: from out4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.28):SA:0(-0.7/5.0):. Processed in 3.000002 secs); 12 Jun 2017 14:46:05 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hkhPE6 uPJjdNV2if89E6DRNcWdR9RQcvf9PKEVqsix4=; b=Lqn2PcQov4aprCr2cdYcdi zAtPpSnbXWy3y98b09IpcRvskUOjTIEcBLbGHmePVo96OgsD/Rx1f6D9QoIxV9X0 Zd2SfZcufFZ3WiPh0ZM+oDUSbu3tuXwKKMzsRzFeIZBDrCEeqdJp2eD5HbB+Z9ES XLebS5ci8LKtC7o2Qr1rzCdz6DU0CHXBHxryHgcL58Yky8DSpEXcPJRw3yfziUtl BeqYkDXI/El/v0zrgXEgPqw1N9DCqO4RhUA+klIOE6LiJFa4eIo7NkcJhKpmNF26 CQPKb/itR8yeJvVWAWhLCVYA36bT2MwQ+pyRrlsDGEuQPllw57a6iL8ZhelSdm/Q == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hkhPE6 uPJjdNV2if89E6DRNcWdR9RQcvf9PKEVqsix4=; b=U4NVQxsKGi/nmQsX6PVkU6 2MIMr9Lcq7Paj3ZRbZY8rDL5eDJCM+nKeW+035NssUNJ+1vjX3ecNrNVAsbZJ8fv 3H5AJo3jFYQ8zfe1JpsneCjNRIbO2vYsMDqVpvdemtvOfQ6bTn1U4g6DaM62hvVb kxLrFN2lt4CE3+IL9r/Oqzr1tdcBaU8IkcFg35Wfu8+chPpKOWhLgZPdJnpumgaG m16O/jPnkebgaSp5w7LM5dPlS6cT6dGDIvZetg7E69qC+qcvRBWqFQwxiriR8EEq EiD4HZQ2ePD5YMB9LJkT8w1IsDEvcbtmf05bFpqymWfCzTjsb/3MOMBPxRgeteUA == X-ME-Sender: Message-Id: <1497278089.1853864.1006670720.0A8DB74D@webmail.messagingengine.com> From: Daniel Shahaf To: Stephane Chazelas Cc: zsh-workers@zsh.org, Eric Cook MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-72fcb609 References: <20170611182045.GA5318@chaz.gmail.com> <20170612060554.GA4709@chaz.gmail.com> Subject: Re: [PATCH2] Re: avoid closed stdin() in zle widgets Date: Mon, 12 Jun 2017 14:34:49 +0000 In-Reply-To: <20170612060554.GA4709@chaz.gmail.com> Stephane Chazelas wrote on Mon, 12 Jun 2017 07:05 +0100: > 2017-06-12 00:15:20 -0400, Eric Cook: > [...] > > > in zle widgets, stdin currently appears to be closed. That's > > > generally not a good idea to close fds 0, 1, 2 as many commands > > > are confused when the files they open suddenly become their > > > stdin/stdout/stderr because the first free fd is 0/1/2. > [...] > > It is documented to work like that in zshzle > [...] > > Well spotted. Thanks. (I also left a diff by mistake for an > unrelated issue discussed earlier on. Sorry about that). > > New patch: > > diff --git a/Doc/Zsh/zle.yo b/Doc/Zsh/zle.yo > index b65e3be..bd0252f 100644 > --- a/Doc/Zsh/zle.yo > +++ b/Doc/Zsh/zle.yo > @@ -750,12 +750,12 @@ sect(User-Defined Widgets) Incompatible changes should be mentioned in NEWS or README. I'm not convinced that the change should be made. Devil's advocate argues that this is a bug in dircolors(1), so (a) as an immediate workaround, people with a buggy dircolors(1) command should redirect stdin from /dev/null when invoking it, (b) those people should fix their dircolors(1) command to not assume fd 0 is open. Daniel