zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH v2] Correct completion of 'tmux new <TAB>'.
Date: Fri, 21 Jul 2017 17:46:03 +0000	[thread overview]
Message-ID: <1500659163.916799.1048510048.293AC92C@webmail.messagingengine.com> (raw)
In-Reply-To: <CAH+w=7ZNhO+C33_o21ZiuDiu_c2zf4rMHSh6PdgGtCXWJ7HPpw@mail.gmail.com>

Bart Schaefer wrote on Thu, 20 Jul 2017 20:12 -0700:
> I believe I understand what this is doing, but "if there is a single
> argument" isn't entirely clear.  It does NOT mean "if there is a
> single positional parameter in the call to this function" (which is
> how I first read it, before I actually looked at the function
> definition); rather it means "if there is more than one word in
> argument position on the command line".
> 

I'll change to your wording before committing.  Thanks for the
blind review!

> Which in turn means this can only be used for argument-rest contexts, correct?

It is designed for this use-case, yes.


  reply	other threads:[~2017-07-21 17:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 21:06 Daniel Shahaf
2017-07-21  3:12 ` Bart Schaefer
2017-07-21 17:46   ` Daniel Shahaf [this message]
2017-07-23  7:48     ` Oliver Kiddle
2017-07-23 14:01       ` Daniel Shahaf
2017-07-25  5:57         ` Oliver Kiddle
2017-07-25 12:01           ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500659163.916799.1048510048.293AC92C@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).