From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34103-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 6595 invoked by alias); 6 Jan 2015 05:25:47 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34103
Received: (qmail 17778 invoked from network); 6 Jan 2015 05:25:34 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=D9vw8UVm c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=YNv0rlydsVwA:10	a=4d3BwcQXmY7Fcw5mHQgA:9 a=CjuIK1q_8ugA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <150105212521.ZM10544@torch.brasslantern.com>
Date: Mon, 05 Jan 2015 21:25:21 -0800
In-reply-to:
 <CAHYJk3QMSktFEHetX-nSgt5Ae=L0eHRHQKqrhHiNz7i6g-tNYg@mail.gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
 "dead code in subst_parse_str" (Jan  6,  1:55am)
References: <CAHYJk3QMSktFEHetX-nSgt5Ae=L0eHRHQKqrhHiNz7i6g-tNYg@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: dead code in subst_parse_str
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jan 6,  1:55am, Mikael Magnusson wrote:
}
} If you look carefully (or at coverity), you'll notice that qt is set
} to 0 initially, and then only toggled to 1 if it is already 1, ie
} never. This is again a case of I have no idea what's happening here,
} so I'll let you guys look at it.

Hmm, looks like it should have been this:

diff --git a/Src/subst.c b/Src/subst.c
index 4100803..610d71e 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -1333,14 +1333,16 @@ subst_parse_str(char **sp, int single, int err)
 	if (!single) {
             int qt = 0;
 
-	    for (; *s; s++)
+	    for (; *s; s++) {
 		if (!qt) {
 		    if (*s == Qstring)
 			*s = String;
 		    else if (*s == Qtick)
 			*s = Tick;
-                } else if (*s == Dnull)
+                }
+		if (*s == Dnull)
                     qt = !qt;
+	    }
 	}
 	return 0;
     }


However, I have no idea in what circumstances that matters.  Obviously
it has been doing something indistinguishable from the right thing with
the dead code for a long time.

-- 
Barton E. Schaefer