From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34124-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 25712 invoked by alias); 6 Jan 2015 07:52:46 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34124
Received: (qmail 1166 invoked from network); 6 Jan 2015 07:52:45 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=Ko/6AtSI c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=YNv0rlydsVwA:10	a=_efP_FDjcVW3DqiJc0gA:9 a=CjuIK1q_8ugA:10 a=AnquxoNnC1kA:10
	a=IFbLQHHRWhQA:10 a=LM9qzwy8soAA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <150105235302.ZM10839@torch.brasslantern.com>
Date: Mon, 05 Jan 2015 23:53:02 -0800
In-reply-to: <1420521949-30483-7-git-send-email-mikachu@gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
 "PATCH 06/17: compctl: Remove pointless check" (Jan  6,  6:25am)
References: <1420521949-30483-1-git-send-email-mikachu@gmail.com>
	<1420521949-30483-7-git-send-email-mikachu@gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: <zsh-workers@zsh.org>
Subject: Re: PATCH 06/17: compctl: Remove pointless check
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jan 6,  6:25am, Mikael Magnusson wrote:
} Subject: PATCH 06/17: compctl: Remove pointless check
}
} cc has already been derefed a bunch of times leading up to here. Found
} by Coverity (Issue 1255841).
} -    if (cc && cc->xor) {
} +    if (cc->xor) {

I'm curious, why bother to "fix" this (and a couple of similar others in
later patches in this series)?  It's not *wrong*, and the change is not
a significant optimization.