From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27147 invoked by alias); 10 Jan 2015 07:08:42 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34204 Received: (qmail 3037 invoked from network); 10 Jan 2015 07:08:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=Kc1larcG c=1 sm=1 tr=0 a=FT8er97JFeGWzr5TCOCO5w==:117 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8 a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10 a=YNv0rlydsVwA:10 a=oIcOuLb3bQnsehPLvzoA:9 a=CjuIK1q_8ugA:10 From: Bart Schaefer Message-id: <150109230839.ZM27191@torch.brasslantern.com> Date: Fri, 09 Jan 2015 23:08:39 -0800 In-reply-to: <1420807419-9270-1-git-send-email-mikachu@gmail.com> Comments: In reply to Mikael Magnusson "PATCH: hist: remove wrong NULL terminator" (Jan 9, 1:43pm) References: <1420807419-9270-1-git-send-email-mikachu@gmail.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: PATCH: hist: remove wrong NULL terminator MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Jan 9, 1:43pm, Mikael Magnusson wrote: } Subject: PATCH: hist: remove wrong NULL terminator } } The result of str[1] = NULL; is then, as far as I can tell, not } anything good. I also can't see any other thing that might have been } intended to be NULL-terminated here, so just remove it. That whole function is a bit odd. It's exported, but nothing calls it except in this file. My compiler doesn't complain if changed to static. And both it and quotebreak() start like quote(char **tr) { char *ptr, *rptr, **str = (char **)tr; what is the cast for if tr is already char** ? Anyway I don't see any reason not to commit the patch from 34178.