From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34305-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 11727 invoked by alias); 16 Jan 2015 16:18:59 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34305
Received: (qmail 28639 invoked from network); 16 Jan 2015 16:18:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=LrklEcZZ c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=8nJEP1OIZ-IA:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=YNv0rlydsVwA:10	a=_A2LDA4udmvvfxybhycA:9 a=wPNLvfGTeEIA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <150116081843.ZM26927@torch.brasslantern.com>
Date: Fri, 16 Jan 2015 08:18:43 -0800
In-reply-to: <20150116125712.3ef52e96@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
 "Re: Crash when capturing command output in completion" (Jan 16, 12:57pm)
References:
 <CACeGjnVCkMZrh4iyAqLeuqPbHE+htd=PRNV10UD8kOry7La_TQ@mail.gmail.com>
	<150115135356.ZM23582@torch.brasslantern.com>
	<CACeGjnVwLgogjoWwCMOk4d-5R+4QOeishx+kYfV0dfE4RS_L6g@mail.gmail.com>
	<150115162748.ZM23670@torch.brasslantern.com>
	<CACeGjnXBn4yE8=_XhEehvKgfNA_Jqk57giED_uym0O3H1=L18A@mail.gmail.com>
	<CACeGjnWw2m5KoZ7EX2u1SoSmNWPVEVUSQsSt4WF4vw3UQ_f7Mw@mail.gmail.com>
	<150115204336.ZM23779@torch.brasslantern.com>
	<150115212036.ZM23929@torch.brasslantern.com>
	<20150116094436.7803b467@pwslap01u.europe.root.pri>
	<20150116125712.3ef52e96@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Crash when capturing command output in completion
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: quoted-printable

On Jan 16, 12:57pm, Peter Stephenson wrote:
}
} Only very lightly tested and so probably partial fix --- however, I'll
} commit this because (i) I'm fairly sure it's going in the right
} direction (ii) it does work in some cases and hence the shell is less
} crash-prone (iii) I get to insert a whiny message about the horrible
} interface which always improves my morale.

OK, this changed something -- I don't get a crash any more (though I
probably should as there is obviously a rogue pointer) but *without*
-DZSH_OLD_SKIPCOMM I get this:

schaefer<501> echo =FF=FF=FF=FF=FF=FF=FF=FF$(ls)
Completing all expansions
=FF=FF=FF=FF=FF=FF=FF=FF$(ls)
Completing original
$(ls)


*With* ZSH_OLD_SKIPCOMM everything works.  So we're looking in the
right place, anyway.