From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: make check problem
Date: Thu, 22 Jan 2015 09:56:10 -0800 [thread overview]
Message-ID: <150122095610.ZM11712@torch.brasslantern.com> (raw)
In-Reply-To: <54C13593.9040602@eastlink.ca>
On Jan 22, 9:38am, Ray Andrews wrote:
}
} Nope. I wonder why 'make check' indicates a fault when the test can't
} possibly succeed from the getgo without that option?
I've said before that "not available" is not a "fault." You're reading
way too much into "make check" skipping a test.
} Are there other
} modules that require that sort of special handling? Why is it special?
Sorry I forgot about --enable-pcre before. You shouldn't link=static
the zsh/pcre module without having used --enable-pcre in configure.
It's special because it's extremely non-standard and changes the meaning
of the expressions on the right-hand-side of the =~ comparison, so if
unknowingly enabled it might break scripts.
} Do I need it anyway?
You only need it if you want to use it.
} Error output:
} (eval):1: command not found: pcre_compile
} (eval):2: command not found: pcre_match
} (eval):10: command not found: pcre_study
Hmm, sorry, my patch in 34338 probably borked this. Try the below:
diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
index 3c25be2..ddfd3f5 100644
--- a/Test/V07pcre.ztst
+++ b/Test/V07pcre.ztst
@@ -5,6 +5,8 @@
ZTST_unimplemented="the zsh/pcre module is not available"
return 0
fi
+# Load the rest of the builtins
+ zmodload zsh/pcre
setopt rematch_pcre
# Find a UTF-8 locale.
setopt multibyte
next prev parent reply other threads:[~2015-01-22 17:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 0:19 completion Ray Andrews
2015-01-17 2:57 ` Command substitution parsing issues (not really Re: completion) Bart Schaefer
2015-01-17 3:29 ` Ray Andrews
2015-01-17 13:25 ` Vin Shelton
2015-01-19 10:29 ` Peter Stephenson
2015-01-19 10:39 ` Peter Stephenson
2015-01-22 0:34 ` make check problem Ray Andrews
2015-01-22 8:49 ` Peter Stephenson
2015-01-22 16:00 ` Ray Andrews
2015-01-22 16:40 ` Jun T.
2015-01-22 17:38 ` Ray Andrews
2015-01-22 17:56 ` Bart Schaefer [this message]
2015-01-22 18:24 ` Ray Andrews
2015-01-23 4:02 ` Bart Schaefer
2015-01-23 4:48 ` Ray Andrews
2015-01-22 19:04 ` --enable-pcre and regex comparison (Was: make check problem) Lawrence Velázquez
2015-01-23 4:04 ` Bart Schaefer
2015-01-18 16:36 ` Command substitution parsing issues (not really Re: completion) Peter Stephenson
2015-01-18 17:31 ` Peter Stephenson
2015-01-18 22:34 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150122095610.ZM11712@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).