From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34379-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 15183 invoked by alias); 25 Jan 2015 03:54:48 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34379
Received: (qmail 17031 invoked from network); 25 Jan 2015 03:54:35 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=b6gFOWC0 c=1 sm=1 tr=0	a=FT8er97JFeGWzr5TCOCO5w==:117
 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8	a=oR5dmqMzAAAA:8 a=-9mUelKeXuEA:10
 a=YNv0rlydsVwA:10	a=tpPEDoYkuupZ2-8tKuQA:9 a=CjuIK1q_8ugA:10 a=9z_PJEc6H6EA:10
	a=IbVBr9DMZmQA:10 a=ed-6-dRnjnQA:10
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <150124195416.ZM3451@torch.brasslantern.com>
Date: Sat, 24 Jan 2015 19:54:16 -0800
In-reply-to:
 <CAHYJk3Qey1gXZ=8d1_FZbYQ2pFd2DHS_eZ-ceP5=JoaOyB+-6A@mail.gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
 "Re: 'cd' built-in crashed zsh on a broken file system" (Jan 24,  8:09pm)
References: <1874234.7FAblKt7ne@kdudka.brq.redhat.com>
	<150120102810.ZM28542@torch.brasslantern.com>
	<20150120203436.4bf346a4@ntlworld.com>
	<CAHYJk3Qey1gXZ=8d1_FZbYQ2pFd2DHS_eZ-ceP5=JoaOyB+-6A@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: 'cd' built-in crashed zsh on a broken file system
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jan 24,  8:09pm, Mikael Magnusson wrote:
}
} This ztrdup triggered a couple of errors in valgrind. Since everything
} else returned from getnameddir seems to be heap allocated, should this
} be dupstring instead?

It should almost certainly match the immediately preceding return in
the other branch of the "if (dir)", yes.