zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Update mtr completion to mtr 0.82
@ 2015-02-07 22:12 Daniel Shahaf
  2015-02-08  0:28 ` Bart Schaefer
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Shahaf @ 2015-02-07 22:12 UTC (permalink / raw)
  To: zsh-workers

---
The -s/-p options are switched, add a few others.

 Completion/Unix/Command/_mtr | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Completion/Unix/Command/_mtr b/Completion/Unix/Command/_mtr
index f4df5b3..5eda9bc 100644
--- a/Completion/Unix/Command/_mtr
+++ b/Completion/Unix/Command/_mtr
@@ -4,13 +4,19 @@ _arguments -C \
   '(-h --help)'{-h,--help}'[help]' \
   '(-v --version)'{-v,--version}'[version]' \
   '(-r --report)'{-r,--report}'[report mode]' \
+  '(-w --report-wide)'{-w,--report-wide}'[wide report mode\: do not truncate hostnames]' \
   '(-c --report-cycles)'{-c,--report-cycles}'[report cycles]:number of pings' \
-  '(-p --psize)'{-p,--psize}'[packet size]:number of bytes' \
+  '(-s --psize)'{-s,--psize}'[packet size]:number of bytes' \
   '(-t --curses)'{-t,--curses}'[curses UI]' \
+  '(-e --mpls)'{-e,--mpls}'[display ICMP MPLS information]' \
+  '(-o --order)'{-o,--order}'[order output fields]:fields order' \
   '(-n --no-dns)'{-n,--no-dns}'[no DNS lookups]' \
   '(-g --gtk)'{-g,--gtk}'[GTK+ UI]' \
-  '(-s --split)'{-s,--split}'[output for a split-user interface]' \
+  '(-p --split)'{-p,--split}'[output for a split-user interface]' \
   '(-l --raw)'{-l,--raw}'[raw output format]' \
   '(-a --address)'{-a,--address}'[source address]:source IP:_hosts' \
   '(-i --interval)'{-i,--interval}'[ping interval]:number of seconds' \
+  '-u[use UDP instead of ICMP echo]' \
+  '-4[use IPv4 only]' \
+  '-6[use IPv6 only]' \
   ':destination host:_hosts'
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Update mtr completion to mtr 0.82
  2015-02-07 22:12 [PATCH] Update mtr completion to mtr 0.82 Daniel Shahaf
@ 2015-02-08  0:28 ` Bart Schaefer
  2015-02-09 14:01   ` Daniel Shahaf
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2015-02-08  0:28 UTC (permalink / raw)
  To: zsh-workers

On Feb 7, 10:12pm, Daniel Shahaf wrote:
}
} The -s/-p options are switched

Has the completion function always had this wrong, or did mtr actually
swap the meaning of these options in a new revision?  Just curious.

-- 
Barton E. Schaefer


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Update mtr completion to mtr 0.82
  2015-02-08  0:28 ` Bart Schaefer
@ 2015-02-09 14:01   ` Daniel Shahaf
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Shahaf @ 2015-02-09 14:01 UTC (permalink / raw)
  To: zsh-workers

Bart Schaefer wrote on Sat, Feb 07, 2015 at 16:28:43 -0800:
> On Feb 7, 10:12pm, Daniel Shahaf wrote:
> }
> } The -s/-p options are switched
> 
> Has the completion function always had this wrong, or did mtr actually
> swap the meaning of these options in a new revision?  Just curious.

I checked; it seems mtr changed the meaning:

% cd mtr-0.85
% grep psize\" -R .
./mtr.c:    { "psize", 1, 0, 's' },	/* changed 'p' to 's' to match ping option


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-09 14:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-07 22:12 [PATCH] Update mtr completion to mtr 0.82 Daniel Shahaf
2015-02-08  0:28 ` Bart Schaefer
2015-02-09 14:01   ` Daniel Shahaf

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).