zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Builtin strftime and TZ assignments
Date: Sat, 21 Feb 2015 16:39:22 -0800	[thread overview]
Message-ID: <150221163922.ZM23297@torch.brasslantern.com> (raw)
In-Reply-To: <20150221231614.3b871425@ntlworld.com>

On Feb 21, 11:16pm, Peter Stephenson wrote:
} Subject: Re: Builtin strftime and TZ assignments
}
} On Sat, 21 Feb 2015 14:54:41 -0800
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > Without it, starting from an unset TZ, doing
} > 
} > torch% TZ=UTC strftime ...
} > 
} > results in TZ remaining set to UTC after strftime completes.  With the
} > pm->level bump, TZ is back to unset again after strftime completes.
} 
} When you say "without", do you mean without setting pm->level at all?

Yes; I assumed incorrectly that passing PM_LOCAL in the flags would cause
createparam() to assign pm->level = locallevel, but obviously I should
have explicitly checked that.  (Why does it not?)

} That wouldn't work because a level is only assigned if you "typeset" or
} equivalent --- a normal assignment creates a global parameter.  But I'd
} expect it to work with locallevel instead of locallevel+1.

It probably does, then, and I was just confused.

} I don't understand the difference if createparam() isn't there.  It
} should always be called by any function that needs to create a parameter.

If you just call setsparam("TZ", ...), it will eventually go through
createparam() and the right thing happens with locallevel, but there's
no way to tell setsparam() [which is just a macro for assignsparam()] to
create the parameter already exported.

Also I now suspect my patch breaks strftime -s, I didn't test that.


  reply	other threads:[~2015-02-22  0:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADjGqHvaOkB-T_qGHDvt9=8TzSGiR8-FptXCX8VNFyfPkmJN-g@mail.gmail.com>
     [not found] ` <CABx2=D9e8KPMd9fxL5UY5BoVOdnNyMx-d2tR3v_4Gmd7V5m7DQ@mail.gmail.com>
     [not found]   ` <150221102305.ZM26540@torch.brasslantern.com>
2015-02-21 20:45     ` Bart Schaefer
2015-02-21 22:04       ` Bart Schaefer
2015-02-21 22:27       ` Peter Stephenson
2015-02-21 22:54         ` Bart Schaefer
2015-02-21 23:16           ` Peter Stephenson
2015-02-22  0:39             ` Bart Schaefer [this message]
2015-02-22  3:53               ` Bart Schaefer
2015-02-22 13:18               ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150221163922.ZM23297@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).