From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Builtin strftime and TZ assignments
Date: Sat, 21 Feb 2015 19:53:21 -0800 [thread overview]
Message-ID: <150221195321.ZM23717@torch.brasslantern.com> (raw)
In-Reply-To: <150221163922.ZM23297@torch.brasslantern.com>
On Feb 21, 4:39pm, Bart Schaefer wrote:
}
} On Feb 21, 11:16pm, Peter Stephenson wrote:
} }
} } That wouldn't work because a level is only assigned if you "typeset" or
} } equivalent --- a normal assignment creates a global parameter. But I'd
} } expect it to work with locallevel instead of locallevel+1.
It does in fact work with locallevel.
} } I don't understand the difference if createparam() isn't there. It
} } should always be called by any function that needs to create a parameter.
}
} If you just call setsparam("TZ", ...), it will eventually go through
} createparam() and the right thing happens with locallevel
Apparently I was confused about that too -- it's the use of the TZ=UTC
prefix which creates and removes again the parameter, not the use of
the parameter scope in bin_strftime().
} Also I now suspect my patch breaks strftime -s, I didn't test that.
Which it does not. Except for one special case: "strftime -s TZ ..."
doesn't change the value of TZ.
Here's a revised patch. Question: How does one know when to metafy() the
value passed to setsparam()? It doesn't appear that getsparam() performs
an unmetafy(), so I presume I can pass directly back to setsparam().
diff --git a/Src/Modules/datetime.c b/Src/Modules/datetime.c
index 00ebd2b..63a04dc 100644
--- a/Src/Modules/datetime.c
+++ b/Src/Modules/datetime.c
@@ -94,7 +94,7 @@ reverse_strftime(char *nam, char **argv, char *scalar, int quiet)
}
static int
-bin_strftime(char *nam, char **argv, Options ops, UNUSED(int func))
+output_strftime(char *nam, char **argv, Options ops, UNUSED(int func))
{
int bufsize, x;
char *endptr = NULL, *scalar = NULL, *buffer;
@@ -145,6 +145,25 @@ bin_strftime(char *nam, char **argv, Options ops, UNUSED(int func))
return 0;
}
+static int
+bin_strftime(char *nam, char **argv, Options ops, int func)
+{
+ int result = 1;
+ char *tz = getsparam("TZ");
+
+ startparamscope();
+ if (tz && *tz) {
+ Param pm = createparam("TZ", PM_LOCAL|PM_SCALAR|PM_EXPORTED);
+ if (pm)
+ pm->level = locallevel; /* because createparam() doesn't */
+ setsparam("TZ", ztrdup(tz));
+ }
+ result = output_strftime(nam, argv, ops, func);
+ endparamscope();
+
+ return result;
+}
+
static zlong
getcurrentsecs(UNUSED(Param pm))
{
next prev parent reply other threads:[~2015-02-22 3:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADjGqHvaOkB-T_qGHDvt9=8TzSGiR8-FptXCX8VNFyfPkmJN-g@mail.gmail.com>
[not found] ` <CABx2=D9e8KPMd9fxL5UY5BoVOdnNyMx-d2tR3v_4Gmd7V5m7DQ@mail.gmail.com>
[not found] ` <150221102305.ZM26540@torch.brasslantern.com>
2015-02-21 20:45 ` Bart Schaefer
2015-02-21 22:04 ` Bart Schaefer
2015-02-21 22:27 ` Peter Stephenson
2015-02-21 22:54 ` Bart Schaefer
2015-02-21 23:16 ` Peter Stephenson
2015-02-22 0:39 ` Bart Schaefer
2015-02-22 3:53 ` Bart Schaefer [this message]
2015-02-22 13:18 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150221195321.ZM23717@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).