From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Testing interactive features (Re: capturing output of !! not working)
Date: Mon, 23 Mar 2015 21:12:41 -0700 [thread overview]
Message-ID: <150323211241.ZM13580@torch.brasslantern.com> (raw)
In-Reply-To: <150323175445.ZM32519@torch.brasslantern.com>
On Mar 23, 5:54pm, Bart Schaefer wrote:
}
} Since writing it, I noticed that history aggressively directs output
} to /dev/tty. I haven't come up with any way to suppress that, and if
} you run it without a tty the stderr pattern does not match.
}
} However, that's not the only test that has problems if there is no tty:
}
} + not interactive and can't open terminal
} + not interactive and can't open terminal
} + not interactive and can't open terminal
} Test ../../zsh-5.0/Test/X02zlevi.ztst failed: error output differs from
Here's a revised Test/W01* that works with no TTY and warns about the
output when there is one, plus a patch to comptest for the Test/X01*
failure with no TTY.
diff --git a/Test/W01history.ztst b/Test/W01history.ztst
new file mode 100644
index 0000000..2492c41
--- /dev/null
+++ b/Test/W01history.ztst
@@ -0,0 +1,19 @@
+# Tests for BANG_HIST replacements
+
+%prep
+
+ [[ -t 0 ]] && print -u $ZTST_fd History tests write to /dev/tty
+
+%test
+
+ $ZTST_testdir/../Src/zsh -fis <<<'
+ echo foo bar
+ echo $(!!) again
+ echo more $( !! )' 2>/dev/null
+0:Regression test for history references in command substitution
+>foo bar
+>foo bar again
+>more foo bar again
+*?*
+F:Check that a history bug introduced by workers/34160 is working again.
+F:Discarded line of error output consumes prompts printed by "zsh -i".
diff --git a/Test/comptest b/Test/comptest
index 9c92f96..ef84217 100644
--- a/Test/comptest
+++ b/Test/comptest
@@ -164,7 +164,7 @@ zletest () {
for input; do
# zpty_flush Before zletest
# sleep for $KEYTIMEOUT
- (( first++ )) && read -t 0.011 -k 1 < /dev/null
+ (( first++ )) && read -t 0.011 -u 0 -k 1 < /dev/null
zpty -n -w zsh "$input"
done
zpty -n -w zsh $'\C-X'
next prev parent reply other threads:[~2015-03-24 4:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:49 capturing output of !! not working Vin Shelton
2015-03-19 2:28 ` Bart Schaefer
2015-03-19 10:57 ` Peter Stephenson
2015-03-19 12:27 ` Vin Shelton
2015-03-19 12:53 ` Peter Stephenson
2015-03-20 10:57 ` Peter Stephenson
2015-03-20 16:04 ` Bart Schaefer
2015-03-22 18:35 ` Peter Stephenson
2015-03-22 19:18 ` Peter Stephenson
2015-03-22 23:22 ` Bart Schaefer
2015-03-23 21:34 ` Peter Stephenson
2015-03-24 0:54 ` Testing interactive features (Re: capturing output of !! not working) Bart Schaefer
2015-03-24 4:12 ` Bart Schaefer [this message]
2015-03-24 4:45 ` Bart Schaefer
2015-03-24 16:09 ` Bart Schaefer
2016-05-23 14:53 ` Mikael Magnusson
2015-03-25 15:48 ` PATCH: Removing aliases from history, 2015 style (was " Peter Stephenson
2015-03-25 17:57 ` PATCH: Removing aliases from history, 2015 style Peter Stephenson
2015-03-25 18:42 ` Mikael Magnusson
2015-03-27 10:06 ` Peter Stephenson
2015-03-27 15:25 ` Bart Schaefer
2015-03-27 15:41 ` Peter Stephenson
2015-03-27 17:17 ` Bart Schaefer
2015-03-27 17:47 ` Peter Stephenson
2015-03-29 18:38 ` Peter Stephenson
2015-03-25 18:58 ` Bart Schaefer
2015-03-25 19:40 ` PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working) Bart Schaefer
2015-03-26 3:43 ` Word breaks around aliased tokens (was Re: PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working)) Bart Schaefer
2015-03-30 18:04 ` Daniel Shahaf
2015-03-30 20:05 ` Mikael Magnusson
2015-03-30 18:08 ` Daniel Shahaf
2015-03-26 9:41 ` PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working) Peter Stephenson
2015-03-26 15:22 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150323211241.ZM13580@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).