From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: William da Silva <w.vigolodasilva@gmail.com>, zsh-workers@zsh.org
Subject: Re: PATCH: improve wording in gpg completion
Date: Fri, 25 Aug 2017 15:31:40 +0000 [thread overview]
Message-ID: <1503675100.2560384.1084973824.4D602EA4@webmail.messagingengine.com> (raw)
In-Reply-To: <CA+Jfsb98DdZB19UXS+RkBqTLzKRxtnOZkgWXX0-sC04NCVMQRw@mail.gmail.com>
William da Silva wrote on Fri, 25 Aug 2017 14:31 +0000:
> diff --git a/Completion/Unix/Command/_gpg b/Completion/Unix/Command/_gpg
> index fe6084f20..44db5e039 100644
> --- a/Completion/Unix/Command/_gpg
> +++ b/Completion/Unix/Command/_gpg
> @@ -26,7 +26,7 @@ fi
> [[ $service = gpgv ]] || args+=(
> '(-e --encrypt)'{-e,--encrypt}'[encrypt data. this option may be
> combined with --sign]'
As you see, your MUA wrapped lines hard, which breaks patches. When
sending patches, either disable line wrapping and whitespace mangling or
send the patches as attachments named *.txt.
> {-d,--decrypt}'[decrypt file or stdin]'
> - '(-c --symmetric)'{-c,--symmetric}'[encrypt with symmetric cypher only]'
> + '(-c --symmetric)'{-c,--symmetric}'[encrypt with symmetric cipher only]'
The man page uses the "cipher" spelling so okay.
> - '--fast-import[import a file without build trustdb]:_files
> attachment:_files'
> + '--fast-import[import a file without adding to trust database]:_files
"trustdb" is used as a noun in the man page so I think we should use it as a
noun here, too. I've omitted this and committed the rest with a tweak to
--edit-key. Thanks for the patch!
Daniel
next prev parent reply other threads:[~2017-08-25 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:31 William da Silva
2017-08-25 15:31 ` Daniel Shahaf [this message]
2017-08-25 15:58 ` William da Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503675100.2560384.1084973824.4D602EA4@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=w.vigolodasilva@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).