From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34877-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 24994 invoked by alias); 12 Apr 2015 19:46:46 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34877
Received: (qmail 24308 invoked from network); 12 Apr 2015 19:46:32 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.2
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=C9H1Upvmu9mBtjYZBPWNX7W0EE1l8rg1SC1Hw4SFRo0=;
        b=WUCojbRzJa4SvpK3Jd6ccHbT458+goT5WPeTDF+sO0zlOGNq8VPiuf/JdYDSFFCaxS
         mUq6XSS0/iM88PCOGK0490B06sBPTTUwzlFmWFx+1hChr+uJR44NAz/jTNVSeJ43c1EY
         zo0fdaz3li1XLXyFy1nVKyMUkL4L8T6ZIqYq1GeOoMaUsstc1qQ/rwgdi7UQcMmOd5i5
         h2ucU9P7PBI5R4P4y73+z5rUzV+D/1fJd7xPFM5rEcafaMOgBAJ20DSO65xf8DKR4CE4
         xvp9Srp0NKANThEF7b72p+3zQkjCpdoUw0ECsPMsZYdzBDlA965Q2d3oeGiEzL0pGtZq
         RvoA==
X-Gm-Message-State: ALoCoQnI1aK4DTrADJprTdQEwCwb2fQFd0nkAaNsOZDfhbmkUdZdyepSqRuL9OustyfkV7WKhuR2
X-Received: by 10.182.250.134 with SMTP id zc6mr9947763obc.78.1428867990494;
        Sun, 12 Apr 2015 12:46:30 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150412124628.ZM22724@torch.brasslantern.com>
Date: Sun, 12 Apr 2015 12:46:28 -0700
In-Reply-To: <150412101826.ZM21679@torch.brasslantern.com>
Comments: In reply to Bart Schaefer <schaefer@brasslantern.com>
        "Re: mkdir completion not offering ignored patterns" (Apr 12, 10:18am)
References: <5528B4C2.3010001@gmail.com> 
	<150411134410.ZM27516@torch.brasslantern.com> 
	<5529A5C2.3090603@gmail.com> 
	<150412101826.ZM21679@torch.brasslantern.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: PATCH: Remove _message call from _mkdir
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Apr 12, 10:18am, Bart Schaefer wrote:
}
} > It works perfectly with all 
} > commands but mkdir, which simply refuses to offer hidden files, ever.
} 
} Which turns out to be that _mkdir calls _message which breaks out of the
} loop over _completers in _main_complete, so the _ignored completer in your
} style is never reached.
} 
} _message really ought to be called only when there is no possibility of
} other completions being generated, not merely to suggest what ought to
} be typed at that point.


Unless someone has a better suggestion?


diff --git a/Completion/Unix/Command/_mkdir b/Completion/Unix/Command/_mkdir
index b5f7519..58d6c74 100644
--- a/Completion/Unix/Command/_mkdir
+++ b/Completion/Unix/Command/_mkdir
@@ -61,7 +61,7 @@ case "$state" in
       [[ $variant == zsh && ${#${${words[2,-1]}:#-*}} -gt 0 ]]; then
       _wanted directories expl \
         'parent directory (alternatively specify name of directory)' \
-        _path_files -/ && ret=0 || _message 'name of directory'
+        _path_files -/ && ret=0
     fi
     ;;
 esac