From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH: Don't define internal params directly in hook function scope
Date: Wed, 29 Apr 2015 21:01:40 -0700 [thread overview]
Message-ID: <150429210140.ZM31974@torch.brasslantern.com> (raw)
In-Reply-To: <1430352483-30739-1-git-send-email-mikachu@gmail.com>
On Apr 30, 2:08am, Mikael Magnusson wrote:
}
} Something feels very wrong about this :). I'm not committing it.
I prefer the original approach, if only because it means you have to
think about what you're doing before mucking with things that are
read-only for a reason.
(I believe the answer about adding a new level of scope around the
"local -h" has appeared on zsh-users before, though I can't think of
a good search term to find it.)
next prev parent reply other threads:[~2015-04-30 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 6:35 [BUG] Can't mark unset variables as read-only Martijn Dekker
2015-04-29 10:36 ` Peter Stephenson
2015-04-29 10:57 ` Mikael Magnusson
2015-04-29 11:01 ` Mikael Magnusson
2015-04-30 0:08 ` PATCH: Don't define internal params directly in hook function scope Mikael Magnusson
2015-04-30 4:01 ` Bart Schaefer [this message]
2015-04-30 8:44 ` Peter Stephenson
2015-04-30 11:18 ` Peter Stephenson
2015-04-29 11:09 ` Local readonly specials (was: Can't mark unset variables as read-only) Peter Stephenson
2015-04-29 13:46 ` [BUG] Can't mark unset variables as read-only Martijn Dekker
2015-04-29 13:55 ` Bart Schaefer
2015-04-29 14:41 ` Peter Stephenson
2015-04-29 15:33 ` Chet Ramey
2015-04-29 19:09 ` Stephane Chazelas
2015-04-29 23:22 ` Chet Ramey
2015-04-30 3:57 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150429210140.ZM31974@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).