From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Don't treat NUL as a combining character
Date: Sat, 9 May 2015 17:14:46 -0700 [thread overview]
Message-ID: <150509171446.ZM15357@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3QkgtwWxMxzpcGHAWBCS+c8fSgBmE0LQ7jnS+-prx8+Nw@mail.gmail.com>
On May 10, 2:02am, Mikael Magnusson wrote:
} Subject: Re: PATCH: Don't treat NUL as a combining character
}
} > -#define IS_COMBINING(wc) (WCWIDTH(wc) == 0 && !iswcntrl(wc))
} > +#define IS_COMBINING(wc) (wc != 0 && WCWIDTH(wc) == 0 && !iswcntrl(wc))
}
} Instead of making this path ever so slightly slower by adding an extra
} test that only matters a fraction of the time
I think the test would be no slower (or at least faster than what you have
there) if you just put the wc != 0 as the last branch of the && chain?
} could we actually make it wc > 127 instead?
I don't know the definitive answer to that, but it seems it should also go
at the end. We're really micro-optimizing here, though.
next prev parent reply other threads:[~2015-05-10 0:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 7:46 Mikael Magnusson
2015-05-10 0:02 ` Mikael Magnusson
2015-05-10 0:14 ` Bart Schaefer [this message]
2015-05-10 0:28 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150509171446.ZM15357@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).