From: Bart Schaefer <schaefer@brasslantern.com>
To: Kamil Dudka <kdudka@redhat.com>, zsh-workers@zsh.org
Subject: Re: another deadlock in free() called from a signal handler
Date: Wed, 13 May 2015 11:01:35 -0700 [thread overview]
Message-ID: <150513110135.ZM28258@torch.brasslantern.com> (raw)
In-Reply-To: <1650705.NsQYeMnTDs@kdudka.brq.redhat.com>
On May 13, 6:37pm, Kamil Dudka wrote:
}
} Wouldn't it be safer to wrap [z]free() internally by the signal
} queuing macros?
Sigh. I'm somewhat resistant to that because if the problem exists with
free() then it probably also exists with other operations at the calling
scope and the farther down we put defensive programming the less likely
we are to get a reproducible bug report for the higher-level problem.
} A backtrace of the deadlock (captured with zsh-4.3.11-3.el6) follows:
}
} #10 0x000000000044a339 in lexrestore () at lex.c:342
The entire lexrestore() function is gone now, and its replacement has
already got the signal queuing wrapped around it. So I think the problem
you're reporting here was already fixed:
commit 8727049674b1f39a8926c02dc74e9f19bbd70289
Author: Barton E. Schaefer <schaefer@zsh.org>
Date: Tue Sep 30 20:34:58 2014 -0700
33298: make lexrestore() more signal-safe
next prev parent reply other threads:[~2015-05-13 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 16:37 Kamil Dudka
2015-05-13 18:01 ` Bart Schaefer [this message]
2015-05-13 20:30 ` Kamil Dudka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150513110135.ZM28258@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=kdudka@redhat.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).