From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11936 invoked by alias); 11 Sep 2017 15:19:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41672 Received: (qmail 24926 invoked by uid 1010); 11 Sep 2017 15:19:27 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-1.9/5.0):. Processed in 2.259372 secs); 11 Sep 2017 15:19:27 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_SOFTFAIL,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: danielsh@apache.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=4LFMmN rlc9vptKA8wLZ6DtVqb3caUBswRRbH7QNQg1c=; b=O1YQuUbYfGnWz25d6jvbzR FNnLX/W8In19zVXBt4dDxma8wQ4Y3uQnZgM9hEI8QFfqetr40Kz68/RTuuHyPowv OkNwwg1br3kegVr37DKwg+2Bje32eTzFjArYd0aiOXBovRYw9VRwgCM2ZHm0WYMh CVzvgQTI2TufAvEou8Sk21+66Cs1u9gZ9NbYJV3D87hluYkP+hKwT3QnMtOMz+DR oFwyizemPMnlCjcakJ1J00PxHbkakOZ2WbxD0jRLyVi1UN/dlX1Z5lHdRH4a8Gkz W+M8db/zOCrprHBehoPjydAplRqBD7tVL5taCDrr9+bPdsL4hvS0ZNqvilLER1LQ == X-ME-Sender: Message-Id: <1505143155.3891161.1102263072.1D722C8A@webmail.messagingengine.com> From: Daniel Shahaf To: zsh-workers@zsh.org Cc: 875460-forwarded@bugs.debian.org, =?utf-8?Q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-973d3087 Date: Mon, 11 Sep 2017 15:19:15 +0000 Subject: Re: zsh: RM_STAR warning counts files as though DOT_GLOB is set In-Reply-To: <20170911150740.pz7fudj5lsflrmtk@tarpaulin.shahaf.local2> References: <20170911143436.GB1960@caska> <20170911150740.pz7fudj5lsflrmtk@tarpaulin.shahaf.local2> Forwarding from Debian: Daniel Shahaf wrote on Mon, 11 Sep 2017 15:07 +0000: > $ zsh -f > % cd $(mktemp -d) > % touch ./foo ./.bar > % rm * > zsh: sure you want to delete all 2 files in /tmp/tmp.65xnqgzMAY [yn]? y > % > % ls -A > .bar > % echo $ZSH_PATCHLEVEL > zsh-5.4.2-1-gab6ac7313 The problem is that it says "2 files" but only one file is deleted. The impedance mismatch is that checkrmall() calls zreaddir(..., unset(GLOBDOTS)), but the second actual argument to zreaddir() governs whether the dot and dot-dot entries would be excluded. Instead, checkrmall() should pass true for the second argument of zreaddir(), and dotfiles should be ignored by some other means when ignoredots is true. (I've just added a docstring to zreaddir() to close the barn door.) I don't understand the last branch of the if/else in that function: it seems to prompt "... delete all the files ..." when count == 0? Cheers, Daniel