From: Bart Schaefer <schaefer@brasslantern.com>
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Smarter matcher-list: skip previous sets
Date: Mon, 18 May 2015 17:44:23 -0700 [thread overview]
Message-ID: <150518174424.ZM2337@torch.brasslantern.com> (raw)
In-Reply-To: <555A63A4.8060809@thequod.de>
On May 19, 12:11am, Daniel Hahler wrote:
}
} I've noticed that my matcher-list setup causes a (possibly expensive)
} completion function to be called multiple times, although the input was
} not be changed by the matcher-list substitution.
}
} I think it would be smart if these calls would be skipped in case the
} input has not changed (because it was all lower-case in the beginning).
Unfortunately the matcher-list is handled as a loop in the shell code in
_main_complete, which has no way to tell whether the "input" is or is not
"changed" by any particular matcher. You're assuming an implementation
of matchers that doesn't (ahem) match what actually happens internally.
Matchers don't "change" the input in any way; they alter the comparison
of the input to the set of possible results, and each such comparison is
independent of those that preceded it. The *output* may be changed based
on which elements of the result set are selected.
--
Barton E. Schaefer
next prev parent reply other threads:[~2015-05-19 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 22:11 Daniel Hahler
2015-05-19 0:44 ` Bart Schaefer [this message]
2015-05-19 8:50 ` Daniel Hahler
2015-05-19 22:55 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150518174424.ZM2337@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).