From: Bart Schaefer <schaefer@brasslantern.com>
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects)
Date: Mon, 18 May 2015 21:37:14 -0700 [thread overview]
Message-ID: <150518213714.ZM6895@torch.brasslantern.com> (raw)
In-Reply-To: <20150519013631.GB2024@tarsus.local2>
On May 19, 1:36am, Daniel Shahaf wrote:
} Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814)
}
} You tried to complete 'git checkout 1<TAB>'. The bug reproduces when
} I do 'git checkout <TAB>', i.e., space-tab, not space-digitone-tab.
OK; I was just trying to repeat what you said in 35127:
> I apply the first patch, Daniel Hahler's recent series, and the second
> attached patch, and then try to complete 'git checkout 1<TAB>',¹ I get
> first a screenful of hashes, and then a screenful of descriptions, and
I now realize that you don't mean "a screenful of ######" but rather a
screenful of git checksums. I've been looking all this time for some
sort of horrible memory scrambling that was filling your screen with
garbage. Sigh.
So ... 35127 deletes/disregards this comment:
- # Note: the after-the-colon part must be unique across the entire array;
- # see workers/34768
It then proceeds to add two completions for each description. The problem
described in 34768 kicks in, and you get the results you observed.
If I modify the _git hunk in 35127 to force one $k part of each pair of
_descr+=(...) assignments to differ, everything works as desired, except
that there are still another duplicate set of everything from 35101.
} I haven't noticed this before, but after pressing space and tab I get
} a "zsh: do you wish to see all 140 possibilities (124 lines)?" prompt
} that I answer 'y' to. The figure 140 is because there are 100
} completions and 40 descriptions; that is, the descriptions are counted
} towards the total number of offered completions. Why would descriptions
} be counted towards the total number of completions?
Side-effect of the problem discussed in 34768, and a clue if we'd noted
it sooner.
I think it's up to you to figure out how to make 34671 work with 35127,
as they are both your patches.
next prev parent reply other threads:[~2015-05-19 4:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 22:05 completion: git: --fixup: problem with _describe -2V and duplicate commit subjects Daniel Hahler
2015-03-24 0:07 ` Daniel Hahler
2015-03-29 5:47 ` Daniel Shahaf
2015-03-30 18:21 ` Daniel Shahaf
2015-05-13 12:41 ` Daniel Hahler
2015-05-14 14:28 ` Daniel Shahaf
2015-05-13 12:44 ` Daniel Hahler
2015-05-14 14:36 ` [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects) Daniel Shahaf
2015-05-16 22:54 ` Daniel Shahaf
2015-05-17 4:07 ` Bart Schaefer
2015-05-17 23:40 ` Daniel Shahaf
2015-05-18 4:00 ` Bart Schaefer
2015-05-19 1:36 ` Daniel Shahaf
2015-05-19 4:37 ` Bart Schaefer [this message]
2015-05-19 20:41 ` Daniel Shahaf
2015-05-19 22:03 ` Bart Schaefer
2015-05-19 20:44 ` Daniel Shahaf
2015-05-19 21:01 ` Daniel Shahaf
2015-05-19 22:23 ` Bart Schaefer
2015-05-20 23:51 ` Daniel Shahaf
2015-05-22 5:02 ` Bart Schaefer
2015-05-23 10:03 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150518213714.ZM6895@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).