From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16235 invoked by alias); 19 May 2015 04:37:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35205 Received: (qmail 4925 invoked from network); 19 May 2015 04:37:22 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type :content-transfer-encoding; bh=VvGF0LM4x8rovCLOUZFuwWTgw0iFKIA6dBOtYoht4Ds=; b=JBRYjDNeHJooltE6hkzXz5LeLVGBFnfyTw6IRj/g+hfLuFav6+17j6zFm3J19bV5A2 M8kqIYBYBam4KzIxiEV+89icbmLk7vrWVLkp5VHH1B+2m6E7TQKWTsejPOLKDVSA5Olp 4nWMOsDbZ3FpVX9cCNONQROrgWyO8JUD8KJw5aa1MwRE7Qx7k2Duo7LDTobWmwCa54tP Lim/uhqQSZnSkgoLN+JuJ7lncfa9AjphYHFWPBp9Xf6efnI14mNGS/KUtgka+qJIv+sK OlWozW9DKpaHiEdFGx/U+CkR/+a/rX2UyNWYgIpzAf5ewT06P9jBebW1k9UrhLkQZop8 ZLDw== X-Gm-Message-State: ALoCoQkyZWWV59ZvbKXIN5xd3XXGNiTh7+cK0Q9tZLd/0iLDNevDn26amUUChCpBZFcWq6VXQSoy X-Received: by 10.107.167.73 with SMTP id q70mr33664045ioe.82.1432010238756; Mon, 18 May 2015 21:37:18 -0700 (PDT) From: Bart Schaefer Message-Id: <150518213714.ZM6895@torch.brasslantern.com> Date: Mon, 18 May 2015 21:37:14 -0700 In-Reply-To: <20150519013631.GB2024@tarsus.local2> Comments: In reply to Daniel Shahaf "Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects)" (May 19, 1:36am) References: <5510AAD4.8040807@thequod.de> <20150329054753.GA2766@tarsus.local2> <20150514143627.GE1932@tarsus.local2> <20150516225422.GH1976@tarsus.local2> <150516210736.ZM4220@torch.brasslantern.com> <20150517234059.GF2214@tarsus.local2> <150517210027.ZM845@torch.brasslantern.com> <20150519013631.GB2024@tarsus.local2> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: "Zsh Hackers' List" Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable On May 19, 1:36am, Daniel Shahaf wrote: } Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814)= =20 } } You tried to complete 'git checkout 1'. The bug reproduces when } I do 'git checkout ', i.e., space-tab, not space-digitone-tab. OK; I was just trying to repeat what you said in 35127: > I apply the first patch, Daniel Hahler's recent series, and the second > attached patch, and then try to complete 'git checkout 1',=B9 I get > first a screenful of hashes, and then a screenful of descriptions, and I now realize that you don't mean "a screenful of ######" but rather a screenful of git checksums. I've been looking all this time for some sort of horrible memory scrambling that was filling your screen with garbage. Sigh. So ... 35127 deletes/disregards this comment: - # Note: the after-the-colon part must be unique across the entire arra= y; - # see workers/34768 It then proceeds to add two completions for each description. The problem described in 34768 kicks in, and you get the results you observed. If I modify the _git hunk in 35127 to force one $k part of each pair of _descr+=3D(...) assignments to differ, everything works as desired, except that there are still another duplicate set of everything from 35101. } I haven't noticed this before, but after pressing space and tab I get } a "zsh: do you wish to see all 140 possibilities (124 lines)?" prompt } that I answer 'y' to. The figure 140 is because there are 100 } completions and 40 descriptions; that is, the descriptions are counted } towards the total number of offered completions. Why would descriptions } be counted towards the total number of completions? Side-effect of the problem discussed in 34768, and a clue if we'd noted it sooner. I think it's up to you to figure out how to make 34671 work with 35127, as they are both your patches.