From: Bart Schaefer <schaefer@brasslantern.com>
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: [PATCH] completion: git: fix __git_commit_objects/__git_recent_commits
Date: Mon, 18 May 2015 21:42:25 -0700 [thread overview]
Message-ID: <150518214225.ZM6990@torch.brasslantern.com> (raw)
In-Reply-To: <555AB200.5050106@thequod.de>
On May 19, 5:46am, Daniel Hahler wrote:
}
} > # Note: the after-the-colon part must be unique across the entire array;
} > # see workers/34768
} > - descr+=("$i:[$i] $k")
} > + descr+=("$i:[$i] ${k//:/\\:}")
}
} Should be good to get committed now - in case it works.
It's not harmful, but it doesn't seem to be necessary either -- the only
colons that need escaping are any that may appear in $i not those in $k.
prev parent reply other threads:[~2015-05-19 4:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 17:37 Daniel Hahler
2015-05-17 17:57 ` Daniel Hahler
2015-05-17 23:46 ` Daniel Shahaf
2015-05-19 3:46 ` Daniel Hahler
2015-05-19 4:42 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150518214225.ZM6990@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).