From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35207-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5876 invoked by alias); 19 May 2015 04:42:32 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35207
Received: (qmail 6540 invoked from network); 19 May 2015 04:42:29 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=IK6pU+S9sEJRlyq8iyyDq1FpYjC2/yDlyNW6HQP1CAg=;
        b=cR8qPlfvhLZewR1ziHCn8uxB+1w6DlfPSaUz8i6cQSgn1cJ1RTQ7bjkrTmcbz6DuG4
         I1HoSzL0fRD2Hz/W4ZCmsYtJHyxaG2NnWB20QV6mno/wZc1tUpVPN9m/bw93od9cNpnH
         KwXPAdjcnv8fOwWAFzg97wepeGfPJsY8QXt+hR7sIGijyZDiIE9tewc4pIIRxyphY7N1
         HXvH0NLj5JwAYeQ2l7pUshRMbQl6kl4iOukjQHv06CSh2JhgYf3cLA9laGYG5zE75Qlk
         dtF2Q96Vdahai6YmWVz7a/clcd4DugE86I/+FkvW3ni3pdAMUd0aKS1yzFzt2zq2rSKi
         i1JA==
X-Gm-Message-State: ALoCoQnc4aBswuoHXIpYcK3zqpvTKqonaxibZl45qBPF414Lj4FCsxxfP4nyv3tZFNG6IsJKE4yM
X-Received: by 10.50.102.68 with SMTP id fm4mr18834074igb.25.1432010547647;
        Mon, 18 May 2015 21:42:27 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150518214225.ZM6990@torch.brasslantern.com>
Date: Mon, 18 May 2015 21:42:25 -0700
In-Reply-To: <555AB200.5050106@thequod.de>
Comments: In reply to Daniel Hahler <genml+zsh-workers@thequod.de>
        "Re: [PATCH] completion: git: fix __git_commit_objects/__git_recent_commits" (May 19,  5:46am)
References: <1431884273-17095-1-git-send-email-genml+zsh-workers@thequod.de> 
	<20150517234642.GI2214@tarsus.local2> 
	<555AB200.5050106@thequod.de>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: [PATCH] completion: git: fix __git_commit_objects/__git_recent_commits
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On May 19,  5:46am, Daniel Hahler wrote:
}
} >      # Note: the after-the-colon part must be unique across the entire array;
} >      # see workers/34768
} > -    descr+=("$i:[$i] $k")
} > +    descr+=("$i:[$i] ${k//:/\\:}")
} 
} Should be good to get committed now - in case it works.

It's not harmful, but it doesn't seem to be necessary either -- the only
colons that need escaping are any that may appear in $i not those in $k.