From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35260-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 6195 invoked by alias); 21 May 2015 21:07:20 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35260
Received: (qmail 7969 invoked from network); 21 May 2015 21:07:19 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no
	version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=nF2YQbyXeQK95kkJNjhZvXQNb5kxOxWVQAWXfJGP9To=;
        b=LJ/LALc4CMnQaHNwySCPOLPl6FvBTykV3OeTDkzx9sJpVtYlXVnaqutt55LrjxtZe6
         GamJP3qKZfVswGUiFARemzvPj4LrhnndEvBBxWmt09OgqqBg7Tb7VJVkNFsyXjuNS9vm
         TxCniHG2y5MjLDAGWHxYJOJZG6zYSqCstZsWRT92Xt4B4zoUVb0gmnx5ZpN60KOzKnCu
         rcprN6Tok5ERGib7c0hknzv5C+RXkWhTDHyLL7LA5V1BUIcyUqQEpeWkpVKedpmST3TH
         Rsm6ZZ5ItRJcC+wyC764ea3Bl6kIjxat6cNoBLy0O9BWOgyJQMlCqn17BFll0UCDNEso
         RVZQ==
X-Gm-Message-State: ALoCoQmc+PSUWJrO/D1wYb3ob2zgH8mhkQ9j7SsHD0CEsdmfGWxpVnuQU3l8008ksL8G6qxuamhy
X-Received: by 10.202.181.11 with SMTP id e11mr3684798oif.107.1432242435541;
        Thu, 21 May 2015 14:07:15 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150521140712.ZM27958@torch.brasslantern.com>
Date: Thu, 21 May 2015 14:07:12 -0700
In-Reply-To: <555E25F2.5080602@thequod.de>
Comments: In reply to Daniel Hahler <genml+zsh-workers@thequod.de>
        "Re: [PATCH] __git_commit_objects_prefer_recent: local ret" (May 21,  8:37pm)
References: <1432229450-21417-1-git-send-email-genml+zsh-workers@thequod.de> 
	<150521110516.ZM27844@torch.brasslantern.com> 
	<555E25F2.5080602@thequod.de>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: [PATCH] __git_commit_objects_prefer_recent: local ret
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On May 21,  8:37pm, Daniel Hahler wrote:
}
} > Wouldn't it make more sense to put "local ret" in _get_recent_commits ?

s/get/git/ (my bad)

} I'm not sure - I've thought it was not used there on purpose, for when
} it gets called for --fixup and --squash?

No, I don't think it is -- "ret" is not declared by _git_commit either,
so the one from _arguments would be getting modified, but that's not part
of the defined interface to _arguments ... it could make _arguments wrong
in the event that _git_recent_commits returns nonzero, in fact.

The right thing is to localize ret and return it (the return statement was
already added by commit 895408bb) both in _git_recent_commits.