zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: zpty-related testsuite failures if building in a chroot on a host running systemd 220 as init system
Date: Sat, 13 Jun 2015 10:43:33 -0700	[thread overview]
Message-ID: <150613104333.ZM1660@torch.brasslantern.com> (raw)
In-Reply-To: <20150613180154.7dbdd1a1@ntlworld.com>

On Jun 13,  6:01pm, Peter Stephenson wrote:
}
} I guess it would be possible to have a "broken posxix_openpt" test ---

Not at configure time -- that would result in the module being left
uncompiled, when in fact outside of the chroot it would work.

} we've done such things before.  But surely if it's possible for the
} system to fix posix_openpt, which must be how it's intended to work,
} we shouldn't need to test...?

I think the test failing here was exactly the right thing, as it led to
the origin of the problem being discovered.  The only viable alternative
would be to report the test as "skipped" which I guess would be OK for
the secondary tests that rely on zpty, but not for V08zpty itself.

I suppose the test suite could remember that V08 failed and therefore
skip X02 and all of Y, so as to isolate the problem better.  We could
add some sort of dependency check.


  reply	other threads:[~2015-06-13 17:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 15:02 Axel Beckert
2015-06-05 15:29 ` Axel Beckert
2015-06-06 10:49 ` Oliver Kiddle
2015-06-06 18:48   ` Axel Beckert
2015-06-12 20:52     ` Axel Beckert
2015-06-13 10:48       ` Axel Beckert
2015-06-13 17:01         ` Peter Stephenson
2015-06-13 17:43           ` Bart Schaefer [this message]
2015-06-15 10:55           ` Axel Beckert
2015-06-16  0:07             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150613104333.ZM1660@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).