From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26142 invoked by alias); 13 Jun 2015 17:43:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35459 Received: (qmail 28716 invoked from network); 13 Jun 2015 17:43:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:in-reply-to:comments :references:to:subject:mime-version:content-type; bh=2UFGPYDsk9wse8hfo7Cip8lHqpXjJeE+Xuhj9g2vqVs=; b=XmOsPbwLuONQjRuVQAnHQjnbz0VhVdntatMbNXBAyLamQhCS9izwkHtUWQofzUGE65 WuixN9A53xluSf/hJL7F9UXme9CeO8YWZy9bS8WPT3+alaCHYfcgfQ/Z0pZi8Iy2QuCZ LDLaTYs8RES0nwz7t/n7u4kSdKUA8QqRu/OEJqc+VuTFiciAF480fbpfvhpT0UUkvb7K h5VRuUKBQfAUAqlguKhYFUnddv2U71JxihxbKJzvaWQIvc6XoXOIqKXSqG/AUY7hMtlU REbT5PKU/9BYAb+CeIAPBs1WB7FtfsxLQRKF5kSL7/09zOLbo9SNv9fUKgdXJg7M4dty aP1A== X-Gm-Message-State: ALoCoQkxvcHzD7R/zS+X67Kj57+H3XmHi3yXrWhLqftkH02hQICPmbgkRyjfuv40D9k3NPRgXiFX X-Received: by 10.202.72.207 with SMTP id v198mr16260275oia.116.1434217418677; Sat, 13 Jun 2015 10:43:38 -0700 (PDT) From: Bart Schaefer Message-Id: <150613104333.ZM1660@torch.brasslantern.com> Date: Sat, 13 Jun 2015 10:43:33 -0700 In-Reply-To: <20150613180154.7dbdd1a1@ntlworld.com> Comments: In reply to Peter Stephenson "Re: zpty-related testsuite failures if building in a chroot on a host running systemd 220 as init system" (Jun 13, 6:01pm) References: <20150605150211.GX4744@sym.noone.org> <6560.1433587795@thecus.kiddle.eu> <20150606184832.GB4744@sym.noone.org> <20150612205228.GQ4744@sym.noone.org> <20150613104857.GV4744@sym.noone.org> <20150613180154.7dbdd1a1@ntlworld.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@zsh.org Subject: Re: zpty-related testsuite failures if building in a chroot on a host running systemd 220 as init system MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 13, 6:01pm, Peter Stephenson wrote: } } I guess it would be possible to have a "broken posxix_openpt" test --- Not at configure time -- that would result in the module being left uncompiled, when in fact outside of the chroot it would work. } we've done such things before. But surely if it's possible for the } system to fix posix_openpt, which must be how it's intended to work, } we shouldn't need to test...? I think the test failing here was exactly the right thing, as it led to the origin of the problem being discovered. The only viable alternative would be to report the test as "skipped" which I guess would be OK for the secondary tests that rely on zpty, but not for V08zpty itself. I suppose the test suite could remember that V08 failed and therefore skip X02 and all of Y, so as to isolate the problem better. We could add some sort of dependency check.