From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26491 invoked by alias); 29 Sep 2017 15:06:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41788 Received: (qmail 20385 invoked by uid 1010); 29 Sep 2017 15:06:34 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 3.792521 secs); 29 Sep 2017 15:06:34 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/zHNH0 igcVIHtg9PuXTkmZhBvHZ2tX40d+XpHGhS21E=; b=smUiGGe0KJf+rDmbyNq6Ih 3vmpUE+QHSCQfxpHev5od/RwmsKk6DU9G4oLRgTbAviUpN8Se6GWekH6RLagAIRV wGM/oQ6t5Siz++pAGSQHJ0wCLwdMKOUfkuK+XZpRRRP0EYp0maO1/5L/ikWMQwxv qzXQOzCccYfirC9n1DUQaxQbTRAcXqEl8u7xSMJKM/QyqL7JF0ZfQI4kBPGN+orK LuSocCY/YJzAeh2RewLGi/uBnAJIx/7UIWx30u9QiPWewh82u8y6OBMzJZiGtr2/ hgBbZnWXxf0TGnxpa6jL6GaFcXms7KWb8Y6PfS5w6HqohD1OoIE2OjTI7L9MjVpw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/zHNH0 igcVIHtg9PuXTkmZhBvHZ2tX40d+XpHGhS21E=; b=QUz9KsbjjfMzh5m5gNuvK1 2yUDjpj3vIOrlrXN08kcqWGqnnHTaFcCtjNsaB857jSwJ1eQb8VWd0chCDQ0rg9x 4IvkSOfkRa1e6EOSWbye6sDzWFiD5ZTabP3ygOCuz6rOoZT8AvafwpGlsumpT5vP Ztdg/uKzla8mTgyaDncrJFEny0/qspUF6iRBuKFeLr49muinF1l3oRVX1VMVqh3p PC2ialUYgp1JgTnTHbuQWYwW4Q3dOipIvZIOc0gKuU426Up9uj1Ez6VmBHprIDK1 vq8ZbqdP5OY2RJCJys8vlmUlDp32JBxZEcJ1qL8boKoHsizx+tpkXZH9UycO6oFA == X-ME-Sender: Message-Id: <1506697584.2841623.1122584064.35F87888@webmail.messagingengine.com> From: Daniel Shahaf To: Peter Stephenson Cc: Zsh hackers list MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-6cb49228 References: <20170813161207.GA6530@chaz.gmail.com> <20170813194939.7a96bc4b@ntlworld.com> <20170814100956.363c7ea8@pwslap01u.europe.root.pri> <20170814201939.22ba0dcb@ntlworld.com> In-Reply-To: <20170814201939.22ba0dcb@ntlworld.com> Date: Fri, 29 Sep 2017 15:06:24 +0000 Subject: Re: fd used for saving redirected fds leaked to child processes Peter Stephenson wrote on Mon, 14 Aug 2017 20:19 +0100: > On Mon, 14 Aug 2017 07:49:52 -0700 > Bart Schaefer wrote: > > On Mon, Aug 14, 2017 at 2:09 AM, Peter Stephenson > > wrote: > > > > > > We need to expose the entire hierarchy for this particular case, but > > > that looks like a stack or a linked list, which seems a little > > > heavyweight for this case. > > > > Another flag in the fdtable array? > > This does that --- this looks easy. It didn't seem convenient to > optimise, since once one set of saved fds is restored, exposing any in > an enclosing scope, there's no way of working out which the new highest > number is without an exhaustive search. This patch introduces a new warning: % Src/zsh -fc ': 3>&1' 1: Src/exec.c:2330: Saved file descriptor not marked as internal It's commit ddb86759012992fa6471bd738f906a4ed434b69f (the log message doesn't include the X-Seq). Found this via z-sy-h's "make quiet-test". Cheers, Daniel