From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35828-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 579 invoked by alias); 19 Jul 2015 08:23:10 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35828
Received: (qmail 10631 invoked from network); 19 Jul 2015 08:23:09 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=/n1V4vrdFxZ4iJX+k1sORaVH+XQfHBoIlSjLBoFTtXo=;
        b=eYs36tquRfAePso6DTNalhhmwrm6oJ5MPKu1XlpYQDntKfxrm63E6+u97xGwhUC8fl
         sW4bHH6EBoThV293cSyMIVRgLyXyRPmPukzpyqxuo0BmPIipnoPa7hwHMGyB47PCPPlo
         6G+5LNv9pPPI8PRK62/4axVXwf527bfDNjrsZwKQmQnCz3FZ+A6UbkgLWU4FXwitwNpw
         2eMm2n+XptS00X85EwKiw6JivtQib1jMpFta8STPjCVUHqj1yqV88gvBclaOW4VgUhaS
         KLPxOLCmDbBye/1h00VxkYkAK6bCbfw0gIVIurevTWLGmPgHlOjtgzXpbnxec3QW4JeX
         V8eg==
X-Gm-Message-State: ALoCoQmAO/0R46le86A8meeGxW/lDghXKA4bXJdUMfccZC9A5GzJ0rFKEErXbF15WTC3nTl5f0hT
X-Received: by 10.202.18.21 with SMTP id 21mr20101370ois.10.1437294188010;
        Sun, 19 Jul 2015 01:23:08 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150719012304.ZM18439@torch.brasslantern.com>
Date: Sun, 19 Jul 2015 01:23:03 -0700
In-Reply-To: <19747.1437278114@thecus.kiddle.eu>
Comments: In reply to Oliver Kiddle <okiddle@yahoo.co.uk>
        "Re: PATCH: narrow-to-region (was Re: This widget implementation feels a bit clunky)" (Jul 19,  5:55am)
References: <CAHYJk3RYUhLuQEvGWLF5sdAK-g=MpiJwV0x-UrfQ35e3r4dHAg@mail.gmail.com> 
	<150620102144.ZM5618@torch.brasslantern.com> 
	<150718164224.ZM4759@torch.brasslantern.com> 
	<19747.1437278114@thecus.kiddle.eu>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: narrow-to-region (was Re: This widget implementation feels a bit clunky)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jul 19,  5:55am, Oliver Kiddle wrote:
}
} How much of emulate zsh is actually needed by narrow-to-region itself?

It uses a bunch of unquoted variable references without braces so it
clearly expects no-shwordsplit and no-ksharrays.  I don't see any need
for extendedglob, on another quick read-through.

} It'd also be good for the function to use the new undo limit features.

I was going to send a follow-up message about undo-ing and whether a call
to split-undo is needed before (and/or after) the recursive-edit.

Related, should -S / -R implicitly set undo points?