From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marco Hinz <mh.codebro@gmail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] edit-command-line breaks arguments with spaces
Date: Sat, 14 Oct 2017 00:07:57 +0000 [thread overview]
Message-ID: <1507939677.3717869.1138301848.03470D9F@webmail.messagingengine.com> (raw)
In-Reply-To: <4B40504C-14CC-4EE0-8A53-5CF67C67E37E@gmail.com>
Marco Hinz wrote on Sat, 14 Oct 2017 01:05 +0200:
> diff --git i/Functions/Zle/edit-command-line w/Functions/Zle/edit-command-line
> index 353f2609a..5c82e823a 100644
> --- i/Functions/Zle/edit-command-line
> +++ w/Functions/Zle/edit-command-line
> @@ -22 +22 @@
> - ${=editor} -c "normal! ${byteoffset}go" -- $1;;
> + eval "${editor[@]} -c 'normal! ${byteoffset}go' -- $1";;
> @@ -25,2 +25,2 @@
> - ${=editor} +${#lines}:$((${#lines[-1]} + 1)) $1;;
> - (*) ${=editor} $1;;
> + eval "${editor[@]} +${#lines}:$((${#lines[-1]} + 1)) $1";;
> + (*) eval "${editor[@]} $1";;
LGTM, except that $1 should be changed into ${(q)1} due to the eval.
next prev parent reply other threads:[~2017-10-14 0:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 23:05 Marco Hinz
2017-10-14 0:07 ` Daniel Shahaf [this message]
2017-10-14 0:45 ` Marco Hinz
2017-10-14 0:55 ` Bart Schaefer
2017-10-14 1:52 ` Daniel Shahaf
2017-10-14 4:21 ` Phil Pennock
2017-10-14 13:57 ` Daniel Shahaf
2017-10-14 1:56 ` Daniel Shahaf
2017-10-14 18:40 ` Marco Hinz
2017-10-15 1:35 ` Bart Schaefer
2017-10-15 14:15 ` Marco Hinz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507939677.3717869.1138301848.03470D9F@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=mh.codebro@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).