From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35992-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19277 invoked by alias); 5 Aug 2015 18:52:58 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35992
Received: (qmail 4346 invoked from network); 5 Aug 2015 18:52:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no
	version=3.4.0
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version:content-type;
        bh=R0Zy8QRR0qX9A1pAyOkONVI8jHjGmunFQpNDHpxAXI8=;
        b=ZQGEe3gyD6ZDOeZlEF6SP9bTsCzsYMXOSmSP/m5r5DOvacRmT5U67rfYw3VCmB5i8T
         a3sJ3/grT36NmDlFcBAvzjvOuTteOoJ1j3UA37PBx420rtbV209FF6iq9YMwRuX7NaxH
         GMwsqd0a36DsS6C26F6Zv2YRweirWCEJQNXXNsagb1czjQW8bIRJR6eG3SLVzW/U8i8L
         /fjfJOFk9IrqX/y5BtInBzaik1xB4ag1EsOslAwswMF5z7kjDoGn4AKCHw2VPCofsKS3
         sz7W17Q/a06ZfnJ1PUDPd4uIMbBVKMDUEnt+OWkeu8feOAaMkQmcCUhkARslO/RIYGbN
         PAZw==
X-Gm-Message-State: ALoCoQnCCOSYuZYYCmnTbZ4vzUQ5D28QJyKJ1LvRQf7ohsrl1vFtFWaOO4i7w6Uc1wFxJOxRv00A
X-Received: by 10.182.63.106 with SMTP id f10mr9307144obs.87.1438800773321;
        Wed, 05 Aug 2015 11:52:53 -0700 (PDT)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <150805115249.ZM7158@torch.brasslantern.com>
Date: Wed, 5 Aug 2015 11:52:49 -0700
In-Reply-To: <CA+=GgY5F-ZD7us6C6-N+3NevKPmVvcJ+Zm7MYp4yDQTZhxY6kg@mail.gmail.com>
Comments: In reply to Mathias Fredriksson <mafredri@gmail.com>
        "Re: Deadlock when receiving kill-signal from child process" (Aug  5,  7:05pm)
References: <CA+=GgY7mHkyK4NJQ6m7y-HpVPKOuKx3-bkJqRHriKzZ662_iwA@mail.gmail.com> 
	<150803085228.ZM24837@torch.brasslantern.com> 
	<CA+=GgY5iZfgUag_V1jqmCv4=PUGBmaV2cNWTDjSO4DAZ+zm-iQ@mail.gmail.com> 
	<150803135818.ZM24977@torch.brasslantern.com> 
	<CA+=GgY7uGzCYEKLBzqrt=ct6q72WFC5w1jMB5RDNe60J-wUz=Q@mail.gmail.com> 
	<150804235400.ZM9958@torch.brasslantern.com> 
	<CA+=GgY5826pmKzn=WHUKCVWOEfRbP=sCN873arRsYHvGgEUb7A@mail.gmail.com> 
	<150805085258.ZM17673@torch.brasslantern.com> 
	<CA+=GgY5F-ZD7us6C6-N+3NevKPmVvcJ+Zm7MYp4yDQTZhxY6kg@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: Deadlock when receiving kill-signal from child process
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Aug 5,  7:05pm, Mathias Fredriksson wrote:
}
} The freezes are now much less frequent, but I still managed to get it
} to lock up with a slightly different gdb trace this time around.

Hm.  I'm a little puzzled by the continued appearance of the "no job
table entry" warning but this --

} #15 <signal handler called>
} #16 0x00007fff896dad62 in tiny_free_list_add_ptr ()
} #17 0x00007fff896d9e7f in szone_free_definite_size ()
} #18 0x000000010365e89a in inputsetline ()

-- is another case where we're manipulating global state without blocking
signal traps.


diff --git a/Src/input.c b/Src/input.c
index 1efabad..cabf942 100644
--- a/Src/input.c
+++ b/Src/input.c
@@ -377,6 +377,8 @@ inputline(void)
 static void
 inputsetline(char *str, int flags)
 {
+    queue_signals();
+
     if ((inbufflags & INP_FREE) && inbuf) {
 	free(inbuf);
     }
@@ -394,6 +396,8 @@ inputsetline(char *str, int flags)
     else
 	inbufct = inbufleft;
     inbufflags = flags;
+
+    unqueue_signals();
 }
 
 /*